Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kps): update to 40.1.* #816

Merged
merged 9 commits into from
Sep 30, 2022
Merged

chore(kps): update to 40.1.* #816

merged 9 commits into from
Sep 30, 2022

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented Sep 26, 2022

Description

Updates KubePrometheuStack to 40.1.*

Changes

Fixes CVE-2021-39226

Prometheus-Operator 0.59.1

Prometheus 2.38.0

Kube-state-metrics 2.6.0 / helm-chart 4.18.0

App

Chart

thanos sidecar 0.28.0

prometheus-node-exporter helm chart 4.2.0 (from 3.3.*)

  • Starting from prometheus-node-exporter version 4.0.0, the node exporter chart is using the Kubernetes recommended labels. Therefore you have to delete the daemonset before you upgrade. If you use your own custom ServiceMonitor or PodMonitor, please ensure to upgrade their selector fields accordingly to the new labels.

App

  • Stays on version 1.3.1

Chart

Grafana from 8.5.13 to 9.1.6

Others

  • Reverted one of the default metrics relabelings for cAdvisor added in 36.x, due to it breaking container_network_* and various other statistics. If you do not want this change, you will need to override the kubelet.cAdvisorMetricRelabelings.

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

Signed-off-by: Toni Tauro toni.tauro@adfinis.com

Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
@eyenx eyenx requested a review from a team as a code owner September 26, 2022 08:39
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2022
@hairmare
Copy link
Contributor

Test breakage is most likely related to this helm unittest release from 21h ago, i'm not sure why we aren't grabbing a specific version tho.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2022
@eyenx eyenx force-pushed the chore/update-kps-to-40 branch 2 times, most recently from 2ae0fbf to a66aaaf Compare September 26, 2022 10:55
@eyenx
Copy link
Member Author

eyenx commented Sep 26, 2022

Test breakage is most likely related to this helm unittest release from 21h ago, i'm not sure why we aren't grabbing a specific version tho.

I now am installing verison 0.2.8 specifically, let me know if there might be a better way to accomplish this

@eyenx
Copy link
Member Author

eyenx commented Sep 26, 2022

nggg I might be too fast quintush/helm-unittest#178

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2022
@isantospardo
Copy link
Contributor

nggg I might be too fast quintush/helm-unittest#178

Nicee, seems to work :)

Copy link
Contributor

@isantospardo isantospardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyenx eyenx enabled auto-merge (squash) September 30, 2022 12:40
@eyenx eyenx merged commit af4d346 into main Sep 30, 2022
@eyenx eyenx deleted the chore/update-kps-to-40 branch September 30, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants