Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-state-metrics] adds deployment annotations for kube-state-metrics #2247

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[kube-state-metrics] adds deployment annotations for kube-state-metrics #2247

merged 1 commit into from
Jul 8, 2022

Conversation

michbeck100
Copy link
Contributor

Signed-off-by: Michael Kotten michaelkotten@gmail.com

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

  • DCO signed
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Copy link
Member

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michbeck100, could you bump the chart version to 4.12.0?

Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump chart version

Signed-off-by: Michael Kotten <michaelkotten@gmail.com>
@michbeck100
Copy link
Contributor Author

bumped

@dotdc dotdc self-assigned this Jul 8, 2022
@dotdc dotdc self-requested a review July 8, 2022 12:14
Copy link
Member

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotdc dotdc requested a review from monotek July 8, 2022 12:14
@dotdc dotdc merged commit 25a875d into prometheus-community:main Jul 8, 2022
@dotdc
Copy link
Member

dotdc commented Jul 8, 2022

Thanks for you contribution @michbeck100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kube-prometheus-stack-operator] Allow adding annotations to the deployment using values file
3 participants