Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-state-metrics] Add selfMonitor.telemetryNodePort field to values #2222

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

AlexHill
Copy link
Contributor

@AlexHill AlexHill commented Jul 4, 2022

What this PR does / why we need it:

Adds a selfMonitor.telemetryNodePort field to values.yaml so that a NodePort for the telemetry endpoint can be specified when service.type is set to NodePort.

Special notes for your reviewer:

Tagging @tariq1890 @mrueg @dotdc as per the PR template comment.

There is a slight incongruence here in that if selfMonitor.telemetryNodePort is specified but service.type is not set to NodePort, the deployment will fail. Options to fix, if desired:

  • put the telemetry endpoint fields under service
  • create separate Services for telemetry and core metrics
  • set the Service type to NodePort if either service.nodePort or selfMonitor.telemetryNodePort are specified

(In the existing chart, the deployment will also fail if services.nodePort is non-zero while services.type is not NodePort - but that's a bit less surprising since the dependent fields are all under the services top-level key.)

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@AlexHill AlexHill changed the title [prometheus-couchdb-exporter] Add selfMonitor.telemetryNodePort field to values [kube-state-metrics] Add selfMonitor.telemetryNodePort field to values Jul 4, 2022
@dotdc
Copy link
Member

dotdc commented Jul 4, 2022

Hi @AlexHill,

I think it's ok to merge as is if you add the limitation in the comment block (see my review)

Signed-off-by: Alex Hill <alex@hill.net.au>
Signed-off-by: Alex Hill <alex@hill.net.au>
@AlexHill
Copy link
Contributor Author

AlexHill commented Jul 4, 2022

Hi @dotdc, thanks for the extremely quick response!

Not sure what's going on but I can't see your review. In any case though I've added a comment now.

Copy link
Member

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotdc
Copy link
Member

dotdc commented Jul 4, 2022

My bad, the review was still pending. Anyway the comment is basically what I suggested.
Thank you for your contribution!

@dotdc dotdc merged commit 61296ef into prometheus-community:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants