-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric for pod tolerations (Ref: #1744) #1769
Add metric for pod tolerations (Ref: #1744) #1769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just one nit from my side
/approve |
This new metric looks good to me, I will approve the change once the tests are green. @Serializator you need to set expectedFamilies to 46 in the tests in order for the tests to pass since you added a new family. |
@dgrisonnet, good one. I will update this at the end of the day. |
ca7a4f8
to
a0980c8
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg, Serializator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds a metric for pod tolerations.
How does this change affect the cardinality of KSM:
It increases the cardinality.
Which issue(s) this PR fixes:
Fixes #1744