[prometheus-node-exporter] Add sidecarHostVolumeMounts #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Huang <git@kevin.huang.to>
zanhsieh
requested changes
Sep 10, 2022
Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Kevin Huang <git@kevin.huang.to>
zanhsieh
approved these changes
Sep 12, 2022
6 tasks
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
May 16, 2023
…mmunity#2441) * feat(prometheus-node-exporter): Add sidecarHostVolumeMounts Signed-off-by: Kevin Huang <git@kevin.huang.to> * Update charts/prometheus-node-exporter/templates/daemonset.yaml Co-authored-by: MH <zanhsieh@gmail.com> Signed-off-by: Kevin Huang <git@kevin.huang.to> Signed-off-by: Kevin Huang <git@kevin.huang.to> Co-authored-by: MH <zanhsieh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Huang git@kevin.huang.to
What this PR does / why we need it
To export the disk's SMART status using a sidecar attached to node-exporter, we would like to mount the /dev from the node to the sidecar in read-only.
To do so, we add a
sidecarHostVolumeMountsvalue, that works similarly toextraHostVolumeMounts.Checklist
[prometheus-couchdb-exporter])