-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nomad): add nomad service discovery #10915
Conversation
4cc5ac9
to
65a8e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pass our HTTP client? Seems like nomad/api supports it.
passed in a httpclient similar to how the consul plugin does it in 3796402 |
I guess it checks the "Support all connection parameters" |
125b157
to
f27aa57
Compare
0293480
to
e08e53d
Compare
@roidelapluie i think i have implemented, tested and documented this now, can you please review again |
fde1146
to
6f53676
Compare
Signed-off-by: Bram Vogelaar <bram@attachmentgenie.com>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
This PR introduces a new service discovery plugin that adds support for the recently announced build service discovery for HashiCorp Nomad. [1][2]. This new plugin will be modeled on the existing Consul plugin.
This PR has implemented the following
[1] https://www.hashicorp.com/blog/nomad-1-3-adds-native-service-discovery-and-edge-workload-support
[2] https://learn.hashicorp.com/tutorials/nomad/schedule-edge-services
Signed-off-by: Bram Vogelaar bram@attachmentgenie.com