feat(nomad): add nomad service discovery #10915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attachmentgenie
force-pushed
the
nomad_sd
branch
4 times, most recently
from
4cc5ac9
to
65a8e67
Compare
daveaugustus
approved these changes
Jun 26, 2022
|
passed in a httpclient similar to how the consul plugin does it in 3796402 |
|
I guess it checks the "Support all connection parameters" |
attachmentgenie
force-pushed
the
nomad_sd
branch
from
125b157
to
f27aa57
Compare
attachmentgenie
changed the title
attachmentgenie
force-pushed
the
nomad_sd
branch
from
0293480
to
e08e53d
Compare
|
@roidelapluie i think i have implemented, tested and documented this now, can you please review again |
attachmentgenie
force-pushed
the
nomad_sd
branch
3 times, most recently
from
fde1146
to
6f53676
Compare
Signed-off-by: Bram Vogelaar <bram@attachmentgenie.com>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new service discovery plugin that adds support for the recently announced build service discovery for HashiCorp Nomad. [1][2]. This new plugin will be modeled on the existing Consul plugin.
This PR has implemented the following
[1] https://www.hashicorp.com/blog/nomad-1-3-adds-native-service-discovery-and-edge-workload-support
[2] https://learn.hashicorp.com/tutorials/nomad/schedule-edge-services
Signed-off-by: Bram Vogelaar bram@attachmentgenie.com