-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for enable_http2
in service monitor, pod monitor and probe
#4836
Comments
enable_http2
in service monitor, pod monitor and probe
/assign |
I ran in to this also, remote_write needs it also. |
This should be the flag: |
The solution would be to extend ServiceMonitor, PodMonitor and Probe CRDs with a new
|
@simonpasquier this is still an issue for remote write. Should I open another issue ? |
@QuentinBisson yes please! |
What did you do?
We're trying to upgrade kube-prometheus-stack to version 2.35
We used to build prometheus image with ENV PROMETHEUS_COMMON_DISABLE_HTTP2=1 in previous versions to turn off http2
but it's no longer working. In version 2.35 new parameter was introduced enable_http2 and it's set to true by default
Did you expect to see some different?
We're unable to set enable_http2 to false for service monitors globally or override existing jobs.
It looks like prometheus operator doesn't handle enable_http2 correctly?
Environment
Prometheus Operator version:
v0.56.2
Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.9", GitCommit:"b631974d68ac5045e076c86a5c66fba6f128dc72", GitTreeState:"clean", BuildDate:"2022-01-19T17:51:12Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.9", GitCommit:"b631974d68ac5045e076c86a5c66fba6f128dc72", GitTreeState:"clean", BuildDate:"2022-01-19T17:45:53Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}
Kubernetes cluster kind:
insert how you created your cluster: kops, bootkube, etc.
Manifests:
Anything else we need to know?:
The text was updated successfully, but these errors were encountered: