[kube-state-metrics]: Configurable extra rules for KSM ClusterRole #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikarlashov
force-pushed
the
extra_rules_for_clusterrole
branch
from
d7032f0
to
f111014
Compare
monotek
requested changes
Jul 8, 2022
ikarlashov
force-pushed
the
extra_rules_for_clusterrole
branch
2 times, most recently
from
e072223
to
a29dea5
Compare
…metheus-community#2231) * fix(alertmanager): 🚑 resolve replicaCount comparision type issue Signed-off-by: Prashant Shahi <me@prashantshahi.dev> * chore(release): 🔖 Bump up alertmanager to 0.18.3 Signed-off-by: Prashant Shahi <me@prashantshahi.dev> * fix(alertmanager): 🚑 backward compatiblity with older version of Helm Signed-off-by: Prashant Shahi <me@prashantshahi.dev> Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
…terRole Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
ikarlashov
force-pushed
the
extra_rules_for_clusterrole
branch
from
c1a17ed
to
853e0ae
Compare
monotek
previously approved these changes
Jul 8, 2022
dotdc
requested changes
Jul 8, 2022
charts/kube-state-metrics/Chart.yaml
Outdated
| @@ -7,7 +7,7 @@ keywords: | |||
| - prometheus | |||
| - kubernetes | |||
| type: application | |||
| version: 4.11.0 | |||
| version: 4.12.0 | |||
There was a problem hiding this comment.
We just released 4.12.0, you need to bump this again sorry
There was a problem hiding this comment.
It happens :) bumped to 4.13.0.
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
|
Thank you for your contribution @ikarlashov ! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding configurable extra rules in ClusterRole. This is required to reach Custom Resources' apiGroups.
Special notes for your reviewer:
This implementation is mandatory to fulfill usage of
--custom-resource-state-config-*flags for KSM, since current version of chart deploys ClusterRole with sufficient privileges only for default k8s objects.Checklist
[prometheus-couchdb-exporter])