-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-state-metrics]: Configurable extra rules for KSM ClusterRole #2249
[kube-state-metrics]: Configurable extra rules for KSM ClusterRole #2249
Conversation
d7032f0
to
f111014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new feature should raise minor version
e072223
to
a29dea5
Compare
…metheus-community#2231) * fix(alertmanager): 🚑 resolve replicaCount comparision type issue Signed-off-by: Prashant Shahi <me@prashantshahi.dev> * chore(release): 🔖 Bump up alertmanager to 0.18.3 Signed-off-by: Prashant Shahi <me@prashantshahi.dev> * fix(alertmanager): 🚑 backward compatiblity with older version of Helm Signed-off-by: Prashant Shahi <me@prashantshahi.dev> Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
…terRole Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
c1a17ed
to
853e0ae
Compare
charts/kube-state-metrics/Chart.yaml
Outdated
@@ -7,7 +7,7 @@ keywords: | |||
- prometheus | |||
- kubernetes | |||
type: application | |||
version: 4.11.0 | |||
version: 4.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just released 4.12.0, you need to bump this again sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It happens :) bumped to 4.13.0.
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution @ikarlashov ! |
What this PR does / why we need it:
Adding configurable extra rules in ClusterRole. This is required to reach Custom Resources' apiGroups.
Special notes for your reviewer:
This implementation is mandatory to fulfill usage of
--custom-resource-state-config-*
flags for KSM, since current version of chart deploys ClusterRole with sufficient privileges only for default k8s objects.Checklist
[prometheus-couchdb-exporter]
)