add new kube_endpoint_address metric #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As KSM shouldn't be responsible for computation of metrics, a new metric is needed to expose available and unavailable addresses of an endpoint. This new metric is generated as a future replacement for kube_endpoint_address_available and kube_endpoint_address_not_ready. Signed-off-by: Mario Constanti <mario@constanti.de>
k8s-ci-robot
added
cncf-cla: yes
3 tasks
fpetkovski
reviewed
Jun 22, 2022
Signed-off-by: Mario Constanti <mario@constanti.de>
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bavarianbidi, dgrisonnet, fpetkovski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As KSM shouldn't be responsible for computation of metrics, a new metric
is needed to expose available and unavailable addresses of an endpoint.
This new metric is generated as a future replacement for
kube_endpoint_address_available and kube_endpoint_address_not_ready.
Signed-off-by: Mario Constanti mario@constanti.de
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases the cardinality of KSM: sum of all IPs in an endpoint subset (
endpoints.subsets.addresses.ipandendpoints.subsets.notReadyAddresses.ip)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Partially solves #1624