Incorporate Cobra #1834
Merged
Incorporate Cobra #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
Closed
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
2 times, most recently
from
f9673d2
to
84d45b9
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
needs-rebase
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
from
84d45b9
to
3b96a1e
Compare
k8s-ci-robot
removed
the
needs-rebase
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
3 times, most recently
from
3c3fff4
to
8ab4cc7
Compare
|
Ready for review. |
k8s-ci-robot
added
the
needs-rebase
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
from
8ab4cc7
to
8c4022b
Compare
k8s-ci-robot
removed
the
needs-rebase
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
from
8c4022b
to
cd9a7f8
Compare
mrueg
reviewed
Nov 8, 2022
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
from
cd9a7f8
to
f7e18c7
Compare
k8s-ci-robot
added
the
needs-rebase
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
from
f7e18c7
to
cbff373
Compare
k8s-ci-robot
removed
the
needs-rebase
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
2 times, most recently
from
e00aa16
to
a04e30e
Compare
Merged
|
Thanks a lot for your work on this @rexagod! |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
s/pflags/cobra/g: * Use spf13/cobra to handle all flags and sub-commands. * Remove all spf13/pflag usage, and fallback to the in-build flag package if, and when needed. * Add completion support. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
force-pushed
the
1791-1-incorporate-cobra
branch
from
a04e30e
to
b926fd9
Compare
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/pflags/cobra/g:
Signed-off-by: Pranshu Srivastava rexagod@gmail.com
How does this change affect the cardinality of KSM: No change.
Which issue(s) this PR fixes: Partially targets #1791 (intentially leaving out the
fixeskeyword here, since this issue to targeted by multiple PRs: #1791 (comment)).