Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Cut v2.7.0 #1896

Merged
merged 20 commits into from
Nov 24, 2022
Merged

*: Cut v2.7.0 #1896

merged 20 commits into from
Nov 24, 2022

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Nov 14, 2022

What this PR does / why we need it:
Next release to be cut this Thursday / promoted Friday. Please let me know if I missed anything important.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
See ChangeLog.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2022
rexagod and others added 5 commits November 16, 2022 11:49
Adds deletionTimestamp metric, for nodes.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Add node deletionTimestamp metric
--config flag defines the path to the kube-state-metrics options config file.
Reload KSM on-the-fly when a change is detected in the configuration.

Meta changes (will squash)
Add end-to-end testing to verify hot-reloading for event-based changes
stemming from the config file. Also,
* sent in a doc fix that was missed
earlier:
https://github.com/kubernetes/kube-state-metrics/pull/1890/files#diff-380eca5a922c0ddbf67f04daefc6823e7ef0e197434d3a826d39c7063cdfa6d6R15,
* updated fsnotify and viper dependencies (v1.6.0 and v1.14.0
  respectively).

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@mrueg
Copy link
Member Author

mrueg commented Nov 20, 2022

I fell sick last week, so will work on this release next week. Apologies for the delay.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2022
k8s-ci-robot and others added 2 commits November 21, 2022 07:44
update kube_node_status_{capacity/allocatable} doc to clarify difference
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@dgrisonnet
Copy link
Member

No worries at all! I think we still wanted to have #1851 in the release anyway.

@rexagod
Copy link
Member

rexagod commented Nov 22, 2022

I've taken #1851 on top priority and I'm working with @mrueg to get this done at the earliest. I really want to see it go in 2.7!

@dgrisonnet
Copy link
Member

No need to put pressure on yourself to have it done for 2.7, we can defer it to the next release and increase the release frequency

@dgrisonnet
Copy link
Member

/lgtm
/hold

@mrueg feel free to remove the hold when you are ready

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 23, 2022
kaitoii11 and others added 7 commits November 23, 2022 23:16
Issue: kubernetes#1711

Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s
version. Since v1.25 has been release we can update it to start using
autoscaler/v2.

Solution: update packages to start using autoscaler/v2

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
Start using autoscaling/v2 for HorizontalPodAutoscaler
Co-authored-by: Damien Grisonnet <damien.grisonnet@epita.fr>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022
k8s-ci-robot and others added 3 commits November 24, 2022 07:40
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@dgrisonnet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrueg
Copy link
Member Author

mrueg commented Nov 24, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit abe3fd3 into kubernetes:release-2.7 Nov 24, 2022
@rexagod
Copy link
Member

rexagod commented Nov 24, 2022

Thank you for driving this all the way, Manuel! 🎉

Vantone pushed a commit to Vantone/kube-state-metrics that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants