Cut 1.0 rc1

[brancz]

I'm inviting everyone to review the changelog to make sure I've not missed anything and thoroughly test this to make sure we have a solid 1.0 release.

@andyxning @fabxc @piosz @matthiasr @loburm

/cc @ethernetdan @julia-stripe

---

This change is 

[k8s-ci-robot]

@brancz: GitHub didn't allow me to request PR reviews from the following users: julia-stripe.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

I'm inviting everyone to review the changelog to make sure I've not missed anything and thoroughly test this to make sure we have a solid 1.0 release.

@andyxning @fabxc @piosz @matthiasr @loburm

/cc @ethernetdan @julia-stripe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabxc]

👍

[andyxning]

And, who is going to push the image to gcr.io.
This is important as we want users testing this release ASAP.

[brancz]

@andyxning I talked to @loburm earlier today and he said he'll take care of it right away.

[andyxning]

👏

[brancz]

Moving forward here, if there are any mistakes in the changelog please comment here or open an issue so we can make sure everything is correct when we release the final 1.0.

[andyxning]

kube_node_disk_pressure metric has been removed in favor of kube_node_status_condition.

I have comment on the changelog before the merge, didn't known why it does not show up.😂

[brancz]

@andyxning I'm not sure I understand your comment. Is there a mistake?

[brancz]

FYI I published an image for testing here: quay.io/coreos/kube-state-metrics:v1.0.0-rc.1

@loburm said he'll push the image to the gcr.io registry within the next half an hour.

[brancz]

@loburm just informed me that the image is now also on gcr: gcr.io/google_containers/kube-state-metrics:v1.0.0-rc.1

[andyxning]

@brancz Sorry for the unclear comment.

I mean in the changelog we add [FEATURE] Add kube_node_status_disk_pressure metric.. And then we add another changelog for removing kube_node_status_disk_pressure in favor of kube_node_status_condition.

This maybe ambiguous and let users think that kube_node_status_disk_pressure metric is available.

How about we remove this line and change this line to:

[CHANGE] Remove `kube_node_status_ready`, `kube_node_status_out_of_disk`, `kube_node_status_memory_pressure` and `kube_node_status_network_unavailable` metrics in favor of one generic `kube_node_status_condition` metric.

[brancz]

Absolutely, that was a mistake, thanks for catching. I believe I meant to insert another metric there but made a copy/paste mistake.

[brancz]

Actually can't find what I wanted to insert there, so I removed the line and opened a PR for it.