-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove incorrect changelog line #199
Conversation
|
I'm not sure I can follow, as the metric was removed and replaced with the generic condition metric. |
change this change log:
to
By removing |
But we did have this metric before: kube-state-metrics/collectors/node.go Line 81 in 804a73c
|
It's my fault. :( I misunderstand you original comment in #198 /lgtm |
No worries, that's why we have reviews 🙂 |
remove incorrect changelog line
remove incorrect changelog line
remove incorrect changelog line
As mentioned in this #198 (comment), this line is incorrect.
@andyxning thanks for catching!
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)