Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect changelog line #199

Merged
merged 1 commit into from
Aug 2, 2017
Merged

remove incorrect changelog line #199

merged 1 commit into from
Aug 2, 2017

Conversation

brancz
Copy link
Member

@brancz brancz commented Aug 2, 2017

As mentioned in this #198 (comment), this line is incorrect.

@andyxning thanks for catching!


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2017
@andyxning
Copy link
Member

kube_node_status_disk_pressure should also be deleted from first change log. :)

@brancz
Copy link
Member Author

brancz commented Aug 2, 2017

I'm not sure I can follow, as the metric was removed and replaced with the generic condition metric.

@andyxning
Copy link
Member

change this change log:

[CHANGE] Remove kube_node_status_ready, kube_node_status_out_of_disk, kube_node_status_memory_pressure, kube_node_status_disk_pressure, and kube_node_status_network_unavailable metrics in favor of one generic kube_node_status_condition metric.

to

[CHANGE] Remove kube_node_status_ready, kube_node_status_out_of_disk, kube_node_status_memory_pressure and kube_node_status_network_unavailable metrics in favor of one generic kube_node_status_condition metric.

By removing kube_node_status_disk_pressure. :)

@brancz
Copy link
Member Author

brancz commented Aug 2, 2017

But we did have this metric before:

"kube_node_status_disk_pressure",

@andyxning
Copy link
Member

It's my fault. :(

I misunderstand you original comment in #198

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2017
@brancz
Copy link
Member Author

brancz commented Aug 2, 2017

No worries, that's why we have reviews 🙂

@brancz brancz merged commit 8254698 into master Aug 2, 2017
@brancz brancz deleted the fix-changelog branch August 2, 2017 14:29
andyxning pushed a commit to andyxning/kube-state-metrics that referenced this pull request Aug 3, 2017
andyxning pushed a commit to andyxning/kube-state-metrics that referenced this pull request Aug 3, 2017
while1malloc0 pushed a commit to while1malloc0/kube-state-metrics that referenced this pull request Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants