-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list/watch access to ClusterRole for CSR collector #717
Conversation
/assign @mxinden |
Changing the target branch to release-1.6, as this is a bug fix. |
Looks good to me. Thanks @dghubble for preparing the pull request right away. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dghubble, mxinden The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also thanks for testing the release candidate! |
There was something else. I was getting pages about specifically kube-state-metrics own desired and ready replicas not matching, though they looked fine to my eye. It may be something on my side, I need to investigate later, but I rolled back to v1.5 for now. I'll followup if I have an actual report. |
* This reverts commit 6e5d66c * kube-state-metrics v1.6.0-rc.0 fires KubeDeploymentReplicasMismatch alerts where its own Deployment doesn't have replicas available, (kube_deployment_status_replicas_available) even though all replicas are available according to kubectl inspection * This problem was present even with the CSR ClusterRole fix (kubernetes/kube-state-metrics#717)
Intended to fix this error log noticed with v1.6.0-rc.0: