Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list/watch access to ClusterRole for CSR collector #717

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add list/watch access to ClusterRole for CSR collector #717

merged 1 commit into from
Apr 10, 2019

Conversation

dghubble
Copy link
Contributor

@dghubble dghubble commented Apr 10, 2019 •
edited

  • Certificate Signing Request collector was added in Add collector for csr #650, but the ClusterRole wasn't updated with access to the resource

Intended to fix this error log noticed with v1.6.0-rc.0:

E0410 06:42:49.568036       1 reflector.go:126] k8s.io/kube-state-metrics/internal/collector/builder.go:482: Failed to list *v1beta1.CertificateSigningRequest: certificatesigningrequests.certificates.k8s.io is forbidden: User "system:serviceaccount:monitoring:kube-state-metrics" cannot list resource "certificatesigningrequests" in API group "certificates.k8s.io" at the cluster scope

@dghubble
Add list/watch access to ClusterRole for CSR collector
f1bda60 
* Certificate Signing Request collector was added in #650, but
the ClusterRole wasn't updated with access to the resource
* #650
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2019
@dghubble
Copy link
Contributor Author

/assign @mxinden

@mxinden mxinden changed the base branch from master to release-1.6 April 10, 2019 07:07
@mxinden
Copy link
Contributor

mxinden commented Apr 10, 2019

Changing the target branch to release-1.6, as this is a bug fix.

@mxinden
Copy link
Contributor

mxinden commented Apr 10, 2019

Looks good to me. Thanks @dghubble for preparing the pull request right away.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dghubble, mxinden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 81a6084 into kubernetes:release-1.6 Apr 10, 2019
@mxinden mxinden mentioned this pull request Apr 10, 2019
Merged
@mxinden
Copy link
Contributor

mxinden commented Apr 10, 2019

Also thanks for testing the release candidate!

@dghubble
Copy link
Contributor Author

There was something else. I was getting pages about specifically kube-state-metrics own desired and ready replicas not matching, though they looked fine to my eye. It may be something on my side, I need to investigate later, but I rolled back to v1.5 for now. I'll followup if I have an actual report.

dghubble added a commit to poseidon/typhoon that referenced this pull request Apr 13, 2019
@dghubble
Revert "Update kube-state-metrics from v1.5.0 to v1.6.0-rc.0"
1b157a2 
* This reverts commit 6e5d66c
* kube-state-metrics v1.6.0-rc.0 fires KubeDeploymentReplicasMismatch
alerts where its own Deployment doesn't have replicas available,
(kube_deployment_status_replicas_available) even though all replicas
are available according to kubectl inspection
* This problem was present even with the CSR ClusterRole fix
(kubernetes/kube-state-metrics#717)
@dghubble dghubble mentioned this pull request Apr 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden Awaiting requested review from mxinden

@tariq1890 tariq1890 Awaiting requested review from tariq1890

Assignees

@mxinden mxinden

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dghubble @mxinden @k8s-ci-robot