Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list/watch access to ClusterRole for CSR collector #718

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Add list/watch access to ClusterRole for CSR collector #718

merged 3 commits into from
Apr 10, 2019

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Apr 10, 2019

Merge #717 back into master.

k8s-ci-robot and others added 3 commits April 8, 2019 02:44
@k8s-ci-robot
Merge pull request #716 from kubernetes/master
d7b8a74 
Merge master into release-1.6 for v1.6.0-rc.0
@dghubble
Add list/watch access to ClusterRole for CSR collector
f1bda60 
* Certificate Signing Request collector was added in #650, but
the ClusterRole wasn't updated with access to the resource
* #650
@k8s-ci-robot
Merge pull request #717 from dghubble/master
81a6084 
Add list/watch access to ClusterRole for CSR collector
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2019
@brancz
Copy link
Member

brancz commented Apr 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, mxinden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f8266a into master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@brancz brancz Awaiting requested review from brancz

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mxinden @brancz @k8s-ci-robot @dghubble