Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump versions of prometheus,kubernetes, and addon-resizer #724

Merged
merged 6 commits into from
Apr 26, 2019

Conversation

tariq1890
Copy link
Contributor

Updating some dependencies.

This should also partly fix #706 .

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2019
@mxinden
Copy link
Contributor

mxinden commented Apr 23, 2019

/approve
/lgtm
/hold

In case this is a bug fix and you would like it to be included in the v1.6.0 release, this pull request should target the release-1.6 branch.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mxinden, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@brancz
Copy link
Member

brancz commented Apr 23, 2019

If I understand #706 correctly this should indeed be in 1.6.

@tariq1890 tariq1890 changed the base branch from master to release-1.6 April 23, 2019 12:44
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2019
@tariq1890
Copy link
Contributor Author

I edited the target branch. I'll leave this for you to decide whether it should be merged or not @mxinden @brancz since the next rc has already been created.

@brancz
Copy link
Member

brancz commented Apr 23, 2019

I'd say let's cut another rc, it doesn't hurt.

@tariq1890
Copy link
Contributor Author

Alright. This will be the last of my PRs. I'll continue the rest after release-1.6 finally goes through.

@mxinden Thoughts on creating a new RC for this? Sorry if this is a bother.

@mxinden
Copy link
Contributor

mxinden commented Apr 26, 2019

/hold cancel

No worries. I will cut another release candidate.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 469c2fe into kubernetes:release-1.6 Apr 26, 2019
@tariq1890 tariq1890 deleted the bump_versions branch April 26, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants