Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the appsv1 apigroup when building the reflector for replicasets. #816

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Use the appsv1 apigroup when building the reflector for replicasets. #816

merged 1 commit into from
Jul 10, 2019

Conversation

tariq1890
Copy link
Contributor

This fixes #815

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2019
@brancz
Copy link
Member

brancz commented Jul 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@brancz
Copy link
Member

brancz commented Jul 10, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@brancz
Copy link
Member

brancz commented Jul 10, 2019

Can you add a changelog entry and bump to rc.1 already?

@tariq1890
Copy link
Contributor Author

Oh yes, will do!

@tariq1890 tariq1890 changed the title use the correct apigroup when building the reflector for replicasets Use the correct apigroup when building the reflector for replicasets Jul 10, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@tariq1890
Copy link
Contributor Author

Done!

brancz
brancz reviewed Jul 10, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tariq1890 tariq1890 changed the title Use the correct apigroup when building the reflector for replicasets Use the correct apigroup when building the reflector for replicasets. Jul 10, 2019
@tariq1890 tariq1890 changed the title Use the correct apigroup when building the reflector for replicasets. Use the appsv1 apigroup when building the reflector for replicasets. Jul 10, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2019
brancz
brancz reviewed Jul 10, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2019
@brancz
Copy link
Member

brancz commented Jul 10, 2019

cc @serathius @piosz @DirectXMan12 please stand by to publish the gcr.io image :)

@brancz
Copy link
Member

brancz commented Jul 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890
Copy link
Contributor Author

@brancz Can we remove the hold?

@brancz
Copy link
Member

brancz commented Jul 10, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit e3d1cab into kubernetes:release-1.7 Jul 10, 2019
@brancz brancz mentioned this pull request Jul 10, 2019
Closed
@tariq1890 tariq1890 deleted the fix_rs branch July 10, 2019 18:41
@lilic
Copy link
Member

lilic commented Jul 11, 2019

@tariq1890 this was not merged into master.

@lilic lilic mentioned this pull request Jul 11, 2019
Merged
@lilic
Copy link
Member

lilic commented Jul 17, 2019

@tariq1890 @brancz I believe it's been 7 days since the release candidate and no new issues were reported so we can do a final release? https://github.com/kubernetes/kube-state-metrics/releases/tag/v1.7.0-rc.1

@tariq1890
Copy link
Contributor Author

No objections from me. Feel free to create a PR to update the release 1.7 branch if you wish. Once @brancz approves and pushes the stable image to quay and gcr, we can publish the stable release.

@lilic lilic mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz left review comments

@mxinden mxinden Awaiting requested review from mxinden

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tariq1890 @brancz @k8s-ci-robot @lilic