Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Cut v1.7.0 release #827

Merged
merged 1 commit into from
Jul 18, 2019
Merged

*: Cut v1.7.0 release #827

merged 1 commit into from
Jul 18, 2019

Conversation

lilic
Copy link
Member

@lilic lilic commented Jul 17, 2019

What this PR does / why we need it:
Cutting v1.7.0 release because, after a testing period of 7 days, there were no additional bugs found or features introduced.

As agreed in #816 (comment)

cc @tariq1890 @brancz

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2019
@lilic
Copy link
Member Author

lilic commented Jul 17, 2019

cc @loburm @piosz could you take care of publish the image to gcr.io when this is approved, thanks!

@tariq1890
Copy link
Contributor

Let's update the version support matrix as well.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2019
@lilic
Copy link
Member Author

lilic commented Jul 17, 2019

@tariq1890 done, thanks!

@tariq1890
Copy link
Contributor

tariq1890 commented Jul 17, 2019 •
edited

Thanks @lilic. I missed to point out one more place. Let's update here as well https://github.com/kubernetes/kube-state-metrics/blob/master/README.md#container-image

@lilic
Copy link
Member Author

lilic commented Jul 17, 2019

@tariq1890 already did that :)

tariq1890
tariq1890 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to publish the the 1.7.0 image to quay and gcr now.

@tariq1890
Copy link
Contributor

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2019
@brancz
Copy link
Member

brancz commented Jul 18, 2019

Thanks a lot for kicking this off!

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, LiliC, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 66ac307 into kubernetes:release-1.7 Jul 18, 2019
@tariq1890
Copy link
Contributor

Awesome! Once published, we should merge the release branch into master.

@brancz
Copy link
Member

brancz commented Jul 18, 2019

Container image published at quay.io/coreos/kube-state-metrics:v1.7.0 and also now the latest image.

@lilic lilic deleted the cut-1.7 branch July 18, 2019 10:14
@loburm
Copy link
Contributor

loburm commented Jul 18, 2019

I have pushed all images to k8s.gcr.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@mxinden mxinden Awaiting requested review from mxinden

Assignees

@tariq1890 tariq1890

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lilic @tariq1890 @brancz @k8s-ci-robot @loburm