-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash due to missing ingress http block #831
Fix crash due to missing ingress http block #831
Conversation
I'm thinking 1.7 only, #830 looks like a candidate for a v1.7.1 as well |
Fine with me. I'll retarget this PR. |
@ebabani Can you rebase this PR against the |
/hold Putting the PR on hold until it's rebased. |
This does not need to be backported to 1.6.x, these metrics were first added in 1.7. I'll rebase the PR |
5ee3a17
to
0470cdc
Compare
/assign @brancz |
I still see non-release commits from the master branch in this PR. Can you fix that? |
0470cdc
to
b9c98b7
Compare
Very odd, but should be fixed now. Sorry about that @tariq1890 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @ebabani !
I will wait on @brancz for final approval :). |
It's acceptable although uncommon for an ingress to have a rule and a host, but no HTTP block for that particular rule.
b9c98b7
to
4d0d772
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, ebabani, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's acceptable although uncommon for an ingress to have a rule and a host,
but no HTTP block for that particular rule.
What this PR does / why we need it:
Fixes a crash when an ingress exists with rules but no
HTTP
block.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #