Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Cut v1.7.1 #833

Merged
merged 1 commit into from
Jul 19, 2019
Merged

*: Cut v1.7.1 #833

merged 1 commit into from
Jul 19, 2019

Conversation

tariq1890
Copy link
Contributor

Includes the following two fixes:

#831 #832

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2019
@tariq1890 tariq1890 changed the base branch from master to release-1.7 July 18, 2019 21:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2019
@tariq1890
Copy link
Contributor Author

/assign @brancz

/hold - Holding to wait for the new container images to be released.

@tariq1890
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2019
@tariq1890
Copy link
Contributor Author

@loburm @piosz Requesting gcr images to be built and pushed for v1.7.1.

lilic
lilic approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should have waited a bit longer, maybe 7 days is not enough?
Or maybe users start using only after a stable release is cut?

LGTM

@loburm
Copy link
Contributor

loburm commented Jul 19, 2019

I think we should somehow change release process. I can't push new gcr image, because there is no 1.7.1 tag. And I assume you don't want to create new tag, because we don't have yet the image?

@tariq1890
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2019
@tariq1890
Copy link
Contributor Author

@lilic Perhaps it's the latter.

@loburm We are definitely open to making changes.

@brancz
Copy link
Member

brancz commented Jul 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f7e59d into kubernetes:release-1.7 Jul 19, 2019
@tariq1890 tariq1890 deleted the cut1.7.1 branch July 19, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@mxinden mxinden Awaiting requested review from mxinden

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tariq1890 @loburm @brancz @k8s-ci-robot @lilic