Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using --skip-phases=addon/coredns still creates kube-dns service #1557

Closed
woopstar opened this issue May 7, 2019 · 13 comments
Closed

Using --skip-phases=addon/coredns still creates kube-dns service #1557

woopstar opened this issue May 7, 2019 · 13 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@woopstar
Copy link
Member

woopstar commented May 7, 2019

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

If you skip the addons/coredns phase upon install, the kube-dns service is still added.

$ kubectl get svc -n kube-system
NAME                   TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)                  AGE
kube-dns               ClusterIP   10.233.0.10    <none>        53/UDP,53/TCP,9153/TCP   8m30s
kubernetes-dashboard   ClusterIP   10.233.60.15   <none>        443/TCP                  6m46s

Versions

kubeadm version (use kubeadm version):

$ kubeadm version
kubeadm version: &version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:08:49Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
```
@yagonobre
Copy link
Member

/assign

@timothysc timothysc added the kind/bug Categorizes issue or PR as related to a bug. label May 7, 2019
@timothysc timothysc added this to the v1.15 milestone May 7, 2019
@timothysc timothysc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 7, 2019
@neolit123 neolit123 self-assigned this May 10, 2019
@yagonobre
Copy link
Member

yagonobre commented May 15, 2019

I can't reproduce it.

kubeadm version
kubeadm version: &version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:08:49Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

sudo kubeadm init --skip-phases addon/coredns

kubectl -n kube-system get svc
No resources found.

@neolit123 neolit123 added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 15, 2019
@neolit123 neolit123 removed this from the v1.15 milestone May 15, 2019
@SataQiu
Copy link
Member

SataQiu commented May 15, 2019

I agree with @yagonobre . I also can't reproduce this probelm.
No DNS pod running.

root@shida-VirtualBox:/tmp# kubectl get pod -n kube-system
NAME                                       READY   STATUS    RESTARTS   AGE
etcd-shida-virtualbox                      1/1     Running   0          3m19s
kube-apiserver-shida-virtualbox            1/1     Running   0          3m39s
kube-controller-manager-shida-virtualbox   1/1     Running   0          3m23s
kube-proxy-k7cmz                           1/1     Running   0          4m27s
kube-scheduler-shida-virtualbox            1/1     Running   0          3m40s

@RA489
Copy link
Contributor

RA489 commented May 15, 2019

@woopstar Do you mind specifying os version you are using?

@woopstar
Copy link
Member Author

I agree with @yagonobre . I also can't reproduce this probelm.
No DNS pod running.

root@shida-VirtualBox:/tmp# kubectl get pod -n kube-system
NAME                                       READY   STATUS    RESTARTS   AGE
etcd-shida-virtualbox                      1/1     Running   0          3m19s
kube-apiserver-shida-virtualbox            1/1     Running   0          3m39s
kube-controller-manager-shida-virtualbox   1/1     Running   0          3m23s
kube-proxy-k7cmz                           1/1     Running   0          4m27s
kube-scheduler-shida-virtualbox            1/1     Running   0          3m40s

It's not a pod, but an svc.

@woopstar
Copy link
Member Author

@woopstar Do you mind specifying os version you are using?

I tried on latest stable coreos. We have the issue at Kubespray and I seached our base code for a kube-dns svc but we don't have any. And we appli the skip phase when we init the master, yet we end up with the kube-dns svc.

@SataQiu
Copy link
Member

SataQiu commented May 15, 2019

@woopstar svc does not exist. 🤷‍♂️

@woopstar
Copy link
Member Author

@woopstar svc does not exist. 🤷‍♂

I'll try investigate this further then. Thanks for checking with me

@RA489
Copy link
Contributor

RA489 commented May 22, 2019

@woopstar didnot got any service running

[root@localhost ~]# kubectl get svc -n kube-system
No resources found.

@yagonobre
Copy link
Member

@woopstar did you have time to confirm if it not a bug?

@RA489
Copy link
Contributor

RA489 commented May 29, 2019

@woopstar did your issue got resolved?

@woopstar
Copy link
Member Author

woopstar commented Jun 11, 2019

Sorry for the delay. Was unable to look into it, but I will have time now.

I think the error might be a logic result in Kubernetes. I waiting for kubernetes-sigs/kubespray#4867 to get merged and see if that actually fixes the problem.

@woopstar
Copy link
Member Author

Looks like this fixed the error. Doing a vagrant up after this PR got merged results in:

k8s-1 core # /opt/bin/kubectl get svc --all-namespaces
NAMESPACE     NAME                   TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)                  AGE
default       kubernetes             ClusterIP   10.233.0.1      <none>        443/TCP                  14m
kube-system   coredns                ClusterIP   10.233.0.3      <none>        53/UDP,53/TCP,9153/TCP   11m

VannTen added a commit to VannTen/kubespray that referenced this issue Dec 6, 2023
Kubeadm dns phase is correctly skipped.
This was a workaround for kubernetes/kubeadm#1557, which was actually
not a bug ; the correct fix was kubernetes-sigs#4867
k8s-ci-robot pushed a commit to kubernetes-sigs/kubespray that referenced this issue Dec 7, 2023
Kubeadm dns phase is correctly skipped.
This was a workaround for kubernetes/kubeadm#1557, which was actually
not a bug ; the correct fix was #4867
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this issue May 8, 2024
…10695)

Kubeadm dns phase is correctly skipped.
This was a workaround for kubernetes/kubeadm#1557, which was actually
not a bug ; the correct fix was kubernetes-sigs#4867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

6 participants