Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodefs becomes imagefs on GCI #33520

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Nodefs becomes imagefs on GCI #33520

merged 1 commit into from
Oct 7, 2016

Conversation

vishh
Copy link
Contributor

@vishh vishh commented Sep 26, 2016 •
edited by k8s-oncall

Kubelet cannot identify rootfs correctly
For #33444

Enforce Disk based pod eviction with GCI base image in Kubelet

Signed-off-by: Vishnu kannan vishnuk@google.com

This change is Reviewable

@vishh
nodefs becomes imagefs on GCI since kubelet cannot identify rootfs co…
e7633d8 
…rrectly

Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh vishh added this to the v1.4-nonblocking milestone Sep 26, 2016
@vishh vishh added release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 26, 2016
@vishh
Copy link
Contributor Author

vishh commented Sep 26, 2016

P2 since it needs to be cherry-picked into 1.4 branch soon for stabilizing GCI tests.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2016
@dchen1107
Copy link
Member

dchen1107 commented Sep 27, 2016 •
edited

Checked the new configuration with @dashpole's newly introduced out-of-inode test on gci image, and it works.

LGTM

@dchen1107 dchen1107 added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Sep 27, 2016
@pwittrock pwittrock modified the milestones: v1.4, v1.4-nonblocking Sep 27, 2016
@vishh vishh mentioned this pull request Sep 27, 2016
Closed
@luxas luxas mentioned this pull request Sep 30, 2016
Merged
@jessfraz
Copy link
Contributor

jessfraz commented Oct 5, 2016

@vishh is this something that needs to be in 1.4.1?

@vishh
Copy link
Contributor Author

vishh commented Oct 6, 2016

@jessfraz Ideally yes. I will try to get the tests to pass tomorrow.

@jessfraz
Copy link
Contributor

jessfraz commented Oct 6, 2016

Thanks!!

On Wednesday, October 5, 2016, Vish Kannan notifications@github.com wrote:

@jessfraz https://github.com/jessfraz Ideally yes. I will try to get
the tests to pass tomorrow.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33520 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbFOlnT0NXlLQJhpDTO62Wmbx7T7Bks5qxDuQgaJpZM4KHEIO
.

@vishh
Copy link
Contributor Author

vishh commented Oct 6, 2016

@k8s-bot node e2e test this github issue #IGNORE

@vishh
Copy link
Contributor Author

vishh commented Oct 6, 2016

@k8s-bot gke e2e test this github issue #IGNORE

@vishh
Copy link
Contributor Author

vishh commented Oct 6, 2016

@jessfraz Tests are green. 🙏 ing for no flakes.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit e7633d8. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jessfraz
Copy link
Contributor

jessfraz commented Oct 6, 2016

i think the submit queue is blocked :(

On Thu, Oct 6, 2016 at 2:40 PM, k8s-ci-robot notifications@github.com
wrote:

Jenkins GKE smoke e2e failed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/33520/kubernetes-pull-build-test-e2e-gke/15718/
for commit e7633d8
e7633d8.
Full PR test history http://pr-test.k8s.io/33520.

The magic incantation to run this job again is @k8s-bot gke e2e test this.
Please help us cut down flakes by linking to an open flake issue
https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open
when you hit one in your PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33520 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbGgQ4NMW0a09NLtCI04xkfxGq36Qks5qxWq7gaJpZM4KHEIO
.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 86c322e into kubernetes:master Oct 7, 2016
@jessfraz jessfraz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 7, 2016
@jessfraz jessfraz mentioned this pull request Oct 7, 2016
Merged
@jessfraz
Copy link
Contributor

jessfraz commented Oct 7, 2016

opened cherrypick here: #34296

k8s-github-robot pushed a commit that referenced this pull request Oct 7, 2016
Merge pull request #34296 from jessfraz/automated-cherry-pick-of-#33520-
9985fc0 
#34251-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #33520 #34251 origin release 1.4

Cherry pick of #33520 #34251 on release-1.4.

#33520: nodefs becomes imagefs on GCI since kubelet cannot identify
#34251: Fix nil pointer issue when getting metrics from volume
@jessfraz
Copy link
Contributor

jessfraz commented Oct 7, 2016

cherry-picked to 1.4 in #34296 so removing cherry-pick candidate

@dashpole dashpole mentioned this pull request Oct 19, 2016
Merged
dashpole added a commit to dashpole/kubernetes that referenced this pull request Oct 22, 2016
@dashpole
Reverted kubernetes#33520, and changed e2e test context to use nodefs
d3ba657
dashpole added a commit to dashpole/kubernetes that referenced this pull request Oct 27, 2016
@dashpole
kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…
eb19713 
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
k8s-github-robot pushed a commit that referenced this pull request Oct 27, 2016
Merge pull request #35136 from dashpole/cadvisor_root_path_configuration
793b000 
Automatic merge from submit-queue

Cadvisor root path configuration

This solves #33444 and reverts PR #33520.  This takes the root directory and passes it to cadvisor, which sets up the "nodefs" based on the provided path, rather than using "/" as before.

This PR is pending on changes in cadvisor, and will not pass tests until those changes are merged, and cadvisor godeps are updated.

```release-note
kubelet summary rootfs now refers to the filesystem that contains the Kubelet RootDirectory (var/lib/kubelet) instead of cadvisor's rootfs ( / ), since they may be different filesystems.
```
jessfraz pushed a commit to jessfraz/kubernetes that referenced this pull request Oct 27, 2016
@dashpole @jessfraz
kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…
f4eeaad 
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
jessfraz pushed a commit to jessfraz/kubernetes that referenced this pull request Oct 28, 2016
@dashpole @jessfraz
kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…
d9a294d 
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#34296 from jessfraz/automated-cherry-pi…
1e1ab5d 
…ck-of-#33520-kubernetes#34251-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#33520 kubernetes#34251 origin release 1.4

Cherry pick of kubernetes#33520 kubernetes#34251 on release-1.4.

kubernetes#33520: nodefs becomes imagefs on GCI since kubelet cannot identify
kubernetes#34251: Fix nil pointer issue when getting metrics from volume
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@dashpole @jessfraz
kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…
2f44e21 
…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vishh @dchen1107 @jessfraz @k8s-ci-robot @k8s-github-robot @googlebot @pwittrock