-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use patched golang1.7.1 for cross-builds targeting darwin #33803
Use patched golang1.7.1 for cross-builds targeting darwin #33803
Conversation
b8d5356
to
f769b02
Compare
Jenkins GCE e2e failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
Jenkins Kubemark GCE e2e failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GCE e2e failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
@ixdy This is fantastic. Does the gcloud CLI kubectl distrubtion use anything else beyond what's OSS and available? I'd love to ensure this change is upstreamed into that tool as well. We'll continue providing 1.3.7 binaries at Deis until GKE makes 1.4 GA. Then I don't see a need for my workaround anymore! |
Jenkins verification failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
@gerred I think the version of The current |
I've built Can someone with macOS Sierra test these binaries to see if they work? Based on |
@luxas Testing now. |
That binary works perfectly. |
This failure:
|
@k8s-bot gci gke e2e test this |
@pwittrock which build was that from? for some reason the GCI and Kubemark builds didn't re-trigger on my last comment. |
@k8s-bot gci gce e2e test this |
Haha, race condition between @ixdy and me :) Let's hope everything's green now @pwittrock When are you planning to release |
@luxas Original plan was a week from Monday (10/10). Need to figure out if this warrants accelerating that timeline. WDYT? |
We'll at least have Jenkins-built |
Nice. I can add that to the known issues in the release notes. Anywhere else we can publish it? |
@pwittrock If possible, I'd prefer the 5th Oct or something like that, given this and the ARM issue. As soon as some other cherrypicks that are pending like #33280, #33520 and #33806 are merged, I think you should release. Then, already more than 20 commits have been merged since v1.4.0, and that's quite a decent amount already WDYT about Wednesday? |
Jenkins GKE smoke e2e failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Jenkins GCI GKE smoke e2e failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
Jenkins unit/integration failed for commit f769b02. Full PR test history. The magic incantation to run this job again is |
@k8s-bot gci gke e2e test this |
@k8s-bot unit test this |
Automatic merge from submit-queue |
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
…f-#33803-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#33803 Cherry pick of kubernetes#33803 on release-1.4. Fixes kubernetes#33801.
This PR extends #32517 to use the patched go1.7.1 introduced by that PR to build all darwin targets (e.g. kubectl).
This is necessary because binaries built with earlier versions of Go regularly segfault on macOS Sierra (see #32999 and #33070).
This solution is somewhat hacky, but we intend to cherry-pick this to 1.4, and switching all of 1.4 to build with go1.7.1 is very high risk.
I haven't yet pushed the cross build image yet, so this will fail to build. Will test locally and update with results.
First step of fixing #33801.
cc @luxas @pwittrock @david-mcmahon @liggitt @smarterclayton @jfrazelle @Starefossen @gerred
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)