-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipset binary for IPVS, context: Fixes #57321 #57648
Add ipset binary for IPVS, context: Fixes #57321 #57648
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
Looks reasonable to me. @Fsero Would you mind bumping the tag too?
|
76daecc
to
bb91e08
Compare
@cblecker done! thanks for the review |
/assign @cblecker |
@Fsero Sorry, a couple other places that need updates too: kubernetes/build/root/WORKSPACE Line 76 in 933272d
|
@cblecker sure, i'll change it and review it more. Thanks! |
bb91e08
to
bc6b0de
Compare
@cblecker changed and reviewed, it looks like this is it |
bc6b0de
to
6fd8903
Compare
@ixdy What else is needed here? |
@Fsero please update |
the patch should look something like: diff --git a/build/root/WORKSPACE b/build/root/WORKSPACE
index 88f35e1eaf..adf0eed006 100644
--- a/build/root/WORKSPACE
+++ b/build/root/WORKSPACE
@@ -67,10 +67,10 @@ docker_pull(
docker_pull(
name = "debian-hyperkube-base-amd64",
- digest = "sha256:fc1b461367730660ac5a40c1eb2d1b23221829acf8a892981c12361383b3742b",
+ digest = "sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b",
registry = "k8s.gcr.io",
repository = "debian-hyperkube-base-amd64",
- tag = "0.8", # ignored, but kept here for documentation
+ tag = "0.9", # ignored, but kept here for documentation
)
docker_pull( |
Automatic merge from submit-queue (batch tested with PRs 59298, 59773, 59772). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bazel: update digests for debian-iptables-amd64 and busybox **What this PR does / why we need it**: I've pushed updated (rebased) versions of the `debian-base-ARCH:0.3` and `debian-iptables-ARCH:v10` images. Since bazel uses the sha256 digest instead of the tag, we need to update those accordingly. I also bumped the busybox digest, which hasn't been updated since last summer. This is updating it from v1.26.2 to v1.28.0. Note that the non-bazel build process uses `busybox:latest`, and so has already been using busybox v1.28.0. **Special notes for your reviewer**: We will update the hyperkube-base image in #57648. **Release note**: ```release-note NONE ``` /assign @tallclair /cc @rphillips @rvkubiak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Why can't we just merge this awesome PR? 😇 |
Yeah please merge that. We need LGTM on this one! @jbeda ? |
/hold |
@ixdy sorry it went under my radar, i've just updated it |
/hold cancel |
perfect, thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, Fsero, gyliu513, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
I think in one of the rebases this missed an update to |
Got a cherry pick up for 1.10 #61861 |
What this PR does / why we need it: Add ipset binary in debian-hyperkube-base which fixes issue 57321
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #57321
Special notes for your reviewer:
Release note: