Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: update digests for debian-iptables-amd64 and busybox #59772

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Feb 12, 2018

What this PR does / why we need it: I've pushed updated (rebased) versions of the debian-base-ARCH:0.3 and debian-iptables-ARCH:v10 images. Since bazel uses the sha256 digest instead of the tag, we need to update those accordingly.

I also bumped the busybox digest, which hasn't been updated since last summer. This is updating it from v1.26.2 to v1.28.0. Note that the non-bazel build process uses busybox:latest, and so has already been using busybox v1.28.0.

Special notes for your reviewer:
We will update the hyperkube-base image in #57648.

Release note:

NONE

/assign @tallclair
/cc @rphillips @rvkubiak

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 12, 2018
@k8s-ci-robot
Copy link
Contributor

@ixdy: GitHub didn't allow me to request PR reviews from the following users: rvkubiak.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it: I've pushed updated (rebased) versions of the debian-base-ARCH:0.3 and debian-iptables-ARCH:v10 images. Since bazel uses the sha256 digest instead of the tag, we need to update those accordingly.

I also bumped the busybox digest, which hasn't been updated since last summer. This is updating it from v1.26.2 to v1.28.0. Note that the non-bazel build process uses busybox:latest, and so has already been using busybox v1.28.0.

Special notes for your reviewer:
We will update the hyperkube-base image in #57648.

Release note:

NONE

/assign @tallclair
/cc @rphillips @rvkubiak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2018
@ixdy
Copy link
Member Author

ixdy commented Feb 12, 2018

hm, bazel + rules_docker do not like that busybox image. will investigate in a bit.

@ixdy ixdy force-pushed the bazel-update-base-images branch from e67c325 to 5259361 Compare February 12, 2018 22:50
@ixdy ixdy changed the title bazel: update digests for debian-iptables-amd64 and busybox bazel: update digest for debian-iptables-amd64 Feb 12, 2018
@ixdy
Copy link
Member Author

ixdy commented Feb 12, 2018

reverted busybox update for now, pending investigation in bazelbuild/rules_docker#320.

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2018
@ixdy ixdy changed the title bazel: update digest for debian-iptables-amd64 bazel: update digests for debian-iptables-amd64 and busybox Feb 12, 2018
@ixdy
Copy link
Member Author

ixdy commented Feb 12, 2018

I figured out how to get the correct digest for busybox after all; the one I was using was referring to the manifest list, which the bazel docker rules can't seem to figure out how to use yet.

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59298, 59773, 59772). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 7ee7e5a into kubernetes:master Feb 13, 2018
@ixdy ixdy deleted the bazel-update-base-images branch May 15, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants