-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: update digests for debian-iptables-amd64 and busybox #59772
bazel: update digests for debian-iptables-amd64 and busybox #59772
Conversation
@ixdy: GitHub didn't allow me to request PR reviews from the following users: rvkubiak. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hm, bazel + rules_docker do not like that busybox image. will investigate in a bit. |
e67c325
to
5259361
Compare
reverted busybox update for now, pending investigation in bazelbuild/rules_docker#320. |
/lgtm |
I figured out how to get the correct digest for busybox after all; the one I was using was referring to the manifest list, which the bazel docker rules can't seem to figure out how to use yet. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
Automatic merge from submit-queue (batch tested with PRs 59298, 59773, 59772). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it: I've pushed updated (rebased) versions of the
debian-base-ARCH:0.3
anddebian-iptables-ARCH:v10
images. Since bazel uses the sha256 digest instead of the tag, we need to update those accordingly.I also bumped the busybox digest, which hasn't been updated since last summer. This is updating it from v1.26.2 to v1.28.0. Note that the non-bazel build process uses
busybox:latest
, and so has already been using busybox v1.28.0.Special notes for your reviewer:
We will update the hyperkube-base image in #57648.
Release note:
/assign @tallclair
/cc @rphillips @rvkubiak