addons registry: Use multi-arch kube-registry-proxy image

[spowelljr]

The existing kube-registry-proxy image (gcr.io/google_containers/kube-registry-proxy) was only built for amd64 and doesn't work for users using QEMU on arm64 machines.

The source code for the image was removed in kubernetes/kubernetes#58564.

I took the source code, updated the nginx base image and added it to https://github.com/spowelljr/kube-registry-proxy and built the kube-registry-proxy image for our five supported architectures and pushed it to gcr.io/k8s-minikube/kube-registry-proxy.

It was confirmed to work by another user as well.
https://kubernetes.slack.com/archives/C1F5CT6Q1/p1684942501397369?thread_ts=1684931469.550259&cid=C1F5CT6Q1

I'm happy to move the source code into the project or into some minikube owned repo.

[spowelljr]

/ok-to-test

[medyagh]

lets create an issue on Kubernetes and ask them where they plan to maintain the deleted code ?

[medyagh]

@BenTheElder mentioned anything under cluster has been depricated, so I think in minikube we should create an issue upstream to see if there is no other sponsor, minikube could host it on our repo

[BenTheElder]

Kubernetes/Kubernetes will not host this anymore since kube-up CI is not using it and excluding the etcd image this directory is only used for CI and not supported anymore (see cluster/README.md) but minikube could host these sources and iterate on it or SIG cluster lifecycle could sponsor bringing it back as a SIG project repo. I suspect the latter will not be supported though based on past conversations.

[BenTheElder]

SIG Testing + Infra is also trying to phase out the rest as well because we need to be running CI on multiple clouds instead of only the GCE bash. We're starting small with just one scale test on kops-aws but the hope is to use kOps AWS+GCE instead of kube-up GCE more generally, eventually. So there's not much future for anything in cluster/. It's barely maintained as-is out of necessity for CI.

[medyagh]

since there is no owner for this image, we could just publish one last patch of it in arm64 but in a follow up PR we could change the ownership of this addon from Google to minikube

[medyagh]

@BenTheElder mentioned anything under cluster has been depricated, so I think in minikube we should create an issue upstream to see if there is no other sponsor, minikube could host it on our repo

[mprimeaux]

@medyagh and @spowelljr I am just catching up with this PR. I had commented here and here in the overall issue.

Let me know if I can help.

[medyagh]

since there is no owner for this image, we could just publish one last patch of it in arm64 but in a follow up PR we could change the ownership of this addon from Google to minikube

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16577) |
+----------------+----------+---------------------+
| minikube start | 53.0s    | 53.4s               |
| enable ingress | 29.7s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 53.3s 53.1s 51.7s 53.4s 53.3s
Times for minikube (PR 16577) start: 52.3s 52.1s 57.8s 50.7s 54.1s

Times for minikube ingress: 28.2s 28.2s 32.7s 28.2s 31.2s
Times for minikube (PR 16577) ingress: 27.7s 27.7s 28.2s 25.1s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16577) |
+----------------+----------+---------------------+
| minikube start | 23.6s    | 24.4s               |
| enable ingress | 23.1s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 16577) ingress: 26.4s 21.4s 21.9s 20.9s 21.4s
Times for minikube ingress: 24.9s 20.9s 21.9s 21.9s 25.9s

Times for minikube start: 25.4s 22.1s 25.7s 22.3s 22.2s
Times for minikube (PR 16577) start: 25.1s 24.6s 24.3s 25.2s 22.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16577) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.1s               |
| enable ingress | 35.6s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.0s 22.6s 22.9s 22.7s 23.6s
Times for minikube (PR 16577) start: 23.0s 20.7s 20.1s 22.8s 23.8s

Times for minikube ingress: 36.4s 31.3s 31.4s 32.4s 46.4s
Times for minikube (PR 16577) ingress: 31.4s 31.4s 31.4s 32.4s 32.4s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestRunningBinaryUpgrade (gopogh)	11.61 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	49.12 (chart)

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment