Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons registry: Use multi-arch kube-registry-proxy image #16577

Merged
merged 2 commits into from
Jun 7, 2023
Merged

addons registry: Use multi-arch kube-registry-proxy image #16577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1bf21
addons registry: Use multi-arch kube-registry-proxy image
spowelljr May 24, 2023
63dea15
update tag
spowelljr May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/minikube/assets/addons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ var Addons = map[string]*Addon{
"0640"),
}, false, "registry", "Google", "", "", map[string]string{
"Registry": "registry:2.8.1@sha256:83bb78d7b28f1ac99c68133af32c93e9a1c149bcd3cb6e683a3ee56e312f1c96",
"KubeRegistryProxy": "google_containers/kube-registry-proxy:0.4@sha256:1040f25a5273de0d72c54865a8efd47e3292de9fb8e5353e3fa76736b854f2da",
"KubeRegistryProxy": "k8s-minikube/kube-registry-proxy:0.0.1@sha256:498e7da3b171e24630615854c4a2924cfb8adbd43b0f252b1458c859ca9b746c",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets create an issue on Kubernetes and ask them where they plan to maintain the deleted code ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenTheElder mentioned anything under cluster has been depricated, so I think in minikube we should create an issue upstream to see if there is no other sponsor, minikube could host it on our repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes/Kubernetes will not host this anymore since kube-up CI is not using it and excluding the etcd image this directory is only used for CI and not supported anymore (see cluster/README.md) but minikube could host these sources and iterate on it or SIG cluster lifecycle could sponsor bringing it back as a SIG project repo. I suspect the latter will not be supported though based on past conversations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIG Testing + Infra is also trying to phase out the rest as well because we need to be running CI on multiple clouds instead of only the GCE bash. We're starting small with just one scale test on kops-aws but the hope is to use kOps AWS+GCE instead of kube-up GCE more generally, eventually. So there's not much future for anything in cluster/. It's barely maintained as-is out of necessity for CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since there is no owner for this image, we could just publish one last patch of it in arm64 but in a follow up PR we could change the ownership of this addon from Google to minikube

}, map[string]string{
"KubeRegistryProxy": "gcr.io",
"Registry": "docker.io",
Expand Down