look for version in bazel-bin #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikedanese: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/blocked-paths
k8s-ci-robot
added
area/release-eng
mikedanese
added
kind/cleanup
k8s-ci-robot
removed
needs-priority
needs-kind
bazel-bin and bazel-genfiles have pointed to the same location since 0.25. -genfiles is deprecated. This was test running: ../release/push-build.sh --release-type=devel \ --bucket=kubernetes-release-mikedanese --private-bucket --nomock \ --version-suffix=mikedanese With bazel version 2.2.0 and 0.23.2. Issue: bazelbuild/bazel#8651
k8s-ci-robot
added
do-not-merge/hold
justaugustus
removed
do-not-merge/blocked-paths
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, justaugustus, mikedanese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel-bin and bazel-genfiles have pointed to the same location since
0.25. -genfiles is deprecated.
This was test running:
With bazel version 2.2.0 and 0.23.2. Not sure how to test ./pkg/release but we have unit tests there.
Issue: bazelbuild/bazel#8651
/assign @justaugustus @fejta