Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push-build: look for version in bazel-bin #1314

Merged
merged 1 commit into from
May 27, 2020
Merged

push-build: look for version in bazel-bin #1314

merged 1 commit into from
May 27, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 27, 2020 •
edited
Loading

What this PR does / why we need it:

Partial cherry pick of #1211
bazel-bin and bazel-genfiles have pointed to the same location since
0.25. -genfiles is deprecated.

Issue: bazelbuild/bazel#8651

Which issue(s) this PR fixes:

We're seeing pull-release-cluster-up job failures on the build-admins branch, specifically in these two PRs: #1250, #1309

cc: @kubernetes/release-engineering
ref: #1250 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 27, 2020
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@justaugustus
Copy link
Member Author

Confirmed we've got a problem with this branch: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/release/1314/pull-release-cluster-up/1265535179099738112/

@justaugustus
push-build: look for version in bazel-bin
e637429 
bazel-bin and bazel-genfiles have pointed to the same location since
0.25. -genfiles is deprecated.

ref: bazelbuild/bazel#8651

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label May 27, 2020
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 27, 2020
@justaugustus justaugustus changed the title [DO NOT MERGE] Test pull-release-cluster-up push-build: look for version in bazel-bin May 27, 2020
@justaugustus
Copy link
Member Author

Traced this to a master PR, that I've updated this PR to partially cherry pick: #1211

/assign @saschagrunert @cpanato @hasheddan
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels May 27, 2020
saschagrunert
saschagrunert approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0a7c40f into kubernetes:build-admins May 27, 2020
@justaugustus justaugustus mentioned this pull request May 27, 2020
Merged
@justaugustus justaugustus mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@idealhack idealhack Awaiting requested review from idealhack

@lachie83 lachie83 Awaiting requested review from lachie83

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @saschagrunert @cpanato @hasheddan