Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom projects from SIG Node test manifests #23822

Closed
3 tasks
ehashman opened this issue Sep 29, 2021 · 28 comments · Fixed by #24039
Closed
3 tasks

Remove custom projects from SIG Node test manifests #23822

ehashman opened this issue Sep 29, 2021 · 28 comments · Fixed by #24039
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@ehashman
Copy link
Member

ehashman commented Sep 29, 2021

What should be cleaned up or changed:

SIG Infra has identified the following GCP projects that they'd like to retire:

SIG Node should remove these explicit projects from jobs wherever possible. A project should be automatically generated/selected. (see e.g. https://github.com/kubernetes/test-infra/pull/23777/files#diff-9495ba672589316a9265fd090ecb9c3c74fd414a11386acafda27df4bd409409)

Provide any links for context:

See also kubernetes/k8s.io#1469

/sig node k8s-infra

@ehashman ehashman added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 29, 2021
@ehashman
Copy link
Member Author

/cc @ameukam

@rayandas
Copy link
Member

/assign

@ameukam
Copy link
Member

ameukam commented Sep 29, 2021

We should firstly identity those master-{blocking,informing} and migrate them before the rest.

@spiffxp
Copy link
Member

spiffxp commented Sep 29, 2021

Related: #23291

Don't ask for a node-e2e project, the default gce-project type should be enough

@spiffxp
Copy link
Member

spiffxp commented Sep 29, 2021

/milestone v1.23
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 29, 2021
@spiffxp spiffxp added this to Needs Triage in sig-k8s-infra via automation Sep 29, 2021
@spiffxp spiffxp moved this from Needs Triage to Backlog (infra to migrate) in sig-k8s-infra Sep 29, 2021
@rayandas
Copy link
Member

rayandas commented Oct 9, 2021

@ameukam I took a good look on this issue today, also rest of the issues and PRs that were mentioned. So we need to remove the listed projects from jobs, is that correct?
And I should raise different PRs for each project cleanup right?
Apologies if I miss something or wrong somewhere. I am still new in these areas.

@ameukam
Copy link
Member

ameukam commented Oct 12, 2021

@ameukam I took a good look on this issue today, also rest of the issues and PRs that were mentioned. So we need to remove the listed projects from jobs, is that correct?

We also want to migrate the release-blocking prowjobs to the community-owned build clusters by adding

cluster: k8s-infra-prow-build

to the spec of the prowjob.

And I should raise different PRs for each project cleanup right? Apologies if I miss something or wrong somewhere. I am still new in these areas.

I would advise doing a few jobs per PR so I can easily monitor the jobs after the flag is dropped and also to start with the periodics.

@ehashman Ouf of curiosity, why do we need a specific bucket (cri-containerd-staging) for the E2E containerd tests ?

@rayandas
Copy link
Member

@ameukam I've raised a PR after identifying master-{blocking,informing} jobs to the community-owned build cluster.
Let me know if it looks good then I will remove the WIP.

@ameukam
Copy link
Member

ameukam commented Oct 18, 2021

@ameukam I've raised a PR after identifying master-{blocking,informing} jobs to the community-owned build cluster. Let me know if it looks good then I will remove the WIP.

@rayandas k8s-infra-prow-build-trusted is also part of the community-owned infrastructure. There is no need to make changes for the jobs using this cluster.

@ameukam
Copy link
Member

ameukam commented Oct 18, 2021

@rayandas #24039 (comment).

@rayandas
Copy link
Member

rayandas commented Oct 18, 2021

@ameukam added sig-node release blocking jobs that needs to migrate to community-owned infrastructure.
Should I add all the sig-node jobs that aren't on k8s-infra-prow-build ?

@rayandas
Copy link
Member

rayandas commented Nov 1, 2021

Hello @ameukam Now I got the requirements here. I just updated the PR for k8s-jkns-pr-node-e2e and will start working on migrating cri-containerd-node-e2e (https://cs.k8s.io/?q=--gcp-project%3Dcri-containerd-node-e2e&i=nope&files=&excludeFiles=&repos=) and raise a different PR (I will also include the community own infrastructure).

Though I need some clarification on this part, like how should I approach and that sort.

K8s-cri-containerd: house of bucket gs://cri-containerd-testing : https://cs.k8s.io/?q=cri-containerd-staging&i=nope&files=&excludeFiles=&repos=

@rayandas
Copy link
Member

It's partially done.
/reopen

@k8s-ci-robot
Copy link
Contributor

@rayandas: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

It's partially done.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayandas
Copy link
Member

@ehashman Please reopen this issue. It's partially done. There will be two more PRs for this issue.
cc: @SergeyKanzhelev

@SergeyKanzhelev
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Member Author

/milestone v1.24

didn't quite finish this and now we're deep in freeze

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.23, v1.24 Nov 24, 2021
@rayandas
Copy link
Member

rayandas commented Jan 7, 2022

K8s-cri-containerd: house of bucket gs://cri-containerd-testing : https://cs.k8s.io/?q=cri-containerd-staging&i=nope&files=&excludeFiles=&repos=

The last part is left now.

/cc: @ameukam

@ehashman
Copy link
Member Author

Quick inventory:

@rayandas
Copy link
Member

I will raise a PR to remove which are left.

@rayandas
Copy link
Member

cri-containerd-node-e2e: #24979
k8s-jkns-pr-node-e2e: #24980

@rayandas
Copy link
Member

@ameukam Could you please shed some light on the third task here whenever you get time?

@ameukam
Copy link
Member

ameukam commented Jan 24, 2022

@ameukam Could you please shed some light on the third task here whenever you get time?

@rayandas Looking at https://cs.k8s.io/?q=gs%3A%2F%2Fcri-containerd-testing&i=nope&files=&excludeFiles=&repos=, I think jobs stopped use k8s-cri-containerd project. we can skip this task for the moment.

@ehashman
Copy link
Member Author

@ameukam can this be closed? I think everything here we need to do is done?

@ameukam
Copy link
Member

ameukam commented Mar 28, 2022

Some jobs still run on Google infrastructure : https://cs.k8s.io/?q=gcp-project%3Dcri-c8d-pr-node-e2e&i=nope&files=&excludeFiles=&repos= but there are related to Containerd. We can close it.

@ehashman
Copy link
Member Author

ehashman commented Apr 4, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@ehashman: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sig-k8s-infra automation moved this from Needs Triage to Done Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Archived in project
sig-k8s-infra
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants