Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-node: migrate away from Google project : k8s-jkns-pr-node-e2e #24039

Merged
merged 1 commit into from
Nov 10, 2021
Merged

sig-node: migrate away from Google project : k8s-jkns-pr-node-e2e #24039

merged 1 commit into from
Nov 10, 2021

Conversation

rayandas
Copy link
Member

This PR migrates release blocking jobs to community-owned build cluster.
partially fixes: #23822

Signed-off-by: Rayan Das rayandas91@gmail.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @rayandas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2021
@rayandas
Copy link
Member Author

/cc: @ameukam

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 18, 2021
@k8s-ci-robot k8s-ci-robot added area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 18, 2021
@ameukam
Copy link
Member

ameukam commented Oct 18, 2021 •
edited
Loading

@rayandas Can you scope this to jobs owned by sig-node (the jobs versioned in https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes/sig-node) ?

@rayandas rayandas force-pushed the migrate-release-blocking-jobs branch from 6b35a49 to 94cc7bc Compare October 18, 2021 18:21
@rayandas rayandas requested a review from ameukam October 18, 2021 18:22
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2021
@ameukam ameukam mentioned this pull request Oct 18, 2021
Closed
3 tasks
@rayandas rayandas force-pushed the migrate-release-blocking-jobs branch from 94cc7bc to 66258d4 Compare October 18, 2021 18:42
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 18, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Oct 20, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Reviewer to PRs Waiting on Author in SIG Node CI/Test Board Oct 20, 2021
ameukam
ameukam reviewed Oct 27, 2021
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml Outdated
cluster: scalability
cluster: k8s-infra-prow-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope. Will be done in #24080

ameukam
ameukam reviewed Oct 27, 2021
View reviewed changes
config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml Outdated
Comment on lines 4 to 5
- name: ci-kubernetes-e2e-kubeadm-kinder-latest
cluster: k8s-infra-prow-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope

@rayandas rayandas force-pushed the migrate-release-blocking-jobs branch from 1bc6c56 to 79ab873 Compare November 9, 2021 17:27
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2021
@rayandas rayandas force-pushed the migrate-release-blocking-jobs branch from 79ab873 to ab40cd5 Compare November 9, 2021 17:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2021
@rayandas rayandas force-pushed the migrate-release-blocking-jobs branch from ab40cd5 to 3a8d39e Compare November 9, 2021 17:51
@rayandas
Copy link
Member Author

rayandas commented Nov 9, 2021

@SergeyKanzhelev @ameukam I fixed the test failures.

@ameukam
Copy link
Member

ameukam commented Nov 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SergeyKanzhelev SergeyKanzhelev moved this from PRs Waiting on Author to PRs - Needs Approver in SIG Node CI/Test Board Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 10, 2021
@rayandas
migrate prowjobs to the community-owned build cluster and remove
147f0c3 
k8s-jkns-pr-node-e2e project from jobs.

Signed-off-by: Rayan Das <rayandas91@gmail.com>
@rayandas rayandas force-pushed the migrate-release-blocking-jobs branch from 3a8d39e to 147f0c3 Compare November 10, 2021 05:29
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 10, 2021
@rayandas
Copy link
Member Author

Fixed conflicts and rebased with upstream/master.

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayandas, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61844e5 into kubernetes:master Nov 10, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

@rayandas: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

This PR migrates release blocking jobs to community-owned build cluster.
partially fixes: #23822

Signed-off-by: Rayan Das rayandas91@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Nov 12, 2021
Merged
@ameukam ameukam mentioned this pull request Jan 6, 2022
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mborsz mborsz Awaiting requested review from mborsz

@neolit123 neolit123 Awaiting requested review from neolit123

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

Remove custom projects from SIG Node test manifests
4 participants
@rayandas @k8s-ci-robot @ameukam @SergeyKanzhelev