-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding node periodic jobs - kubetest2 #24308
Conversation
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Hi @Namanl2001. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
ci-docker-node-conformance-kubetest2
job
/ok-to-test |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
testgrid-tab-name: docker-node-conformance-kubetest2 | ||
spec: | ||
containers: | ||
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20211108-d0d3c6d7a8-experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requests and limits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what type of requests and limits are you talking about? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I remember in one of previous PRs I saw the note that requests and limits will be needed on all containers (#24039 (comment)). but I don't know details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requests and limits are only required for jobs running on k8s-infra-prow-build*
(aka field cluster: k8s-infra-prow-build
) clusters. They can be added now or when sig-node prowjobs will be migrated to the community-owned infrastructure.
fork-per-release-periodic-interval: 1h 2h 6h 24h | ||
testgrid-dashboards: sig-release-master-blocking, sig-node-release-blocking | ||
testgrid-tab-name: node-kubelet-master-kubetest2 | ||
testgrid-alert-email: kubernetes-sig-node+testgrid@googlegroups.com,kubernetes-sig-node-test-failures@googlegroups.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we can start without e-mail notifications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like tests need this alert to get passed.
Must have alert_options
ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/24308/pull-test-infra-unit-test/1459117935019692032
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, can we please only keep kubernetes-sig-node-test-failures@googlegroups.com
, thank you
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
hold for the comment on limits and requests, feel free to unhold
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Namanl2001, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@Namanl2001: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- name: ci-docker-node-conformance-kubetest2 | ||
interval: 2h | ||
decorate: true | ||
path_alias: k8s.io/kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be replaced with a full ref under extra_refs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
Signed-off-by: Namanl2001 namanlakhwani@gmail.com
This PR is part of the CI migration from kubetest to kubetest2
https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration
cc: @dims @spiffxp @amwat