Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding node periodic jobs - kubetest2 #24308

Merged
merged 6 commits into from
Nov 17, 2021
Merged

adding node periodic jobs - kubetest2 #24308

merged 6 commits into from
Nov 17, 2021

Conversation

Namanl2001
Copy link
Member

Signed-off-by: Namanl2001 namanlakhwani@gmail.com

This PR is part of the CI migration from kubetest to kubetest2
https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration

cc: @dims @spiffxp @amwat

@Namanl2001
adding job
3d7ac4c 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Namanl2001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 10, 2021
@Namanl2001
adding command to runner.sh
8240ec1 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
adding kubelet kubetest2 job
440ef36 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001 Namanl2001 changed the title adding ci-docker-node-conformance-kubetest2 job adding node periodic jobs - kubetest2 Nov 10, 2021
@dims
Copy link
Member

dims commented Nov 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2021
@SergeyKanzhelev
Copy link
Member

/assign

amwat
amwat reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
SergeyKanzhelev
SergeyKanzhelev reviewed Nov 11, 2021
View reviewed changes
config/jobs/kubernetes/sig-node/node-docker.yaml Show resolved Hide resolved
config/jobs/kubernetes/sig-node/node-docker.yaml
testgrid-tab-name: docker-node-conformance-kubetest2
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20211108-d0d3c6d7a8-experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests and limits?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what type of requests and limits are you talking about? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I remember in one of previous PRs I saw the note that requests and limits will be needed on all containers (#24039 (comment)). but I don't know details

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so I didn't add them as there were no requests and limits present in the corresponding non-kubetest2 job.
I also don't know if it's needed.

cc: @ameukam @amwat

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requests and limits are only required for jobs running on k8s-infra-prow-build* (aka field cluster: k8s-infra-prow-build) clusters. They can be added now or when sig-node prowjobs will be migrated to the community-owned infrastructure.

config/jobs/kubernetes/sig-node/node-kubelet.yaml Outdated
fork-per-release-periodic-interval: 1h 2h 6h 24h
testgrid-dashboards: sig-release-master-blocking, sig-node-release-blocking
testgrid-tab-name: node-kubelet-master-kubetest2
testgrid-alert-email: kubernetes-sig-node+testgrid@googlegroups.com,kubernetes-sig-node-test-failures@googlegroups.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we can start without e-mail notifications?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like tests need this alert to get passed.

Must have alert_options ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/24308/pull-test-infra-unit-test/1459117935019692032

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, can we please only keep kubernetes-sig-node-test-failures@googlegroups.com, thank you

@Namanl2001
remove email-alert
a583e71 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
correcting skip regex
930033b 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@Namanl2001
adding email alert
699e7a3 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

hold for the comment on limits and requests, feel free to unhold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2021
@dims
Copy link
Member

dims commented Nov 17, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Namanl2001, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SergeyKanzhelev
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit d7ac385 into kubernetes:master Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

@Namanl2001: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-docker.yaml using file config/jobs/kubernetes/sig-node/node-docker.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

Signed-off-by: Namanl2001 namanlakhwani@gmail.com

This PR is part of the CI migration from kubetest to kubetest2
https://github.com/kubernetes/enhancements/tree/master/keps/sig-testing/2464-kubetest2-ci-migration

cc: @dims @spiffxp @amwat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea mentioned this pull request Nov 17, 2021
Closed
amwat
amwat reviewed Nov 17, 2021
View reviewed changes
config/jobs/kubernetes/sig-node/node-docker.yaml
- name: ci-docker-node-conformance-kubetest2
interval: 2h
decorate: true
path_alias: k8s.io/kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be replaced with a full ref under extra_refs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- org: kubernetes
  repo: kubernetes
  base_ref: master
  path_alias: k8s.io/kubernetes

@Namanl2001 Namanl2001 mentioned this pull request Nov 18, 2021
Merged
@Namanl2001 Namanl2001 deleted the kubetest2-job branch November 22, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@amwat amwat amwat left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dims dims

@SergeyKanzhelev SergeyKanzhelev

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node CI/Test Board MIGRATED-use h...
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Namanl2001 @k8s-ci-robot @dims @SergeyKanzhelev @ameukam @amwat