Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][sig-node] node-kubelet-master-kubetest2, docker-node-conformance-kubetest2 #24409

Merged
merged 3 commits into from
Nov 23, 2021
Merged

[Fix][sig-node] node-kubelet-master-kubetest2, docker-node-conformance-kubetest2 #24409

merged 3 commits into from
Nov 23, 2021

Conversation

Namanl2001
Copy link
Member

@Namanl2001 Namanl2001 commented Nov 18, 2021 •
edited
Loading

Signed-off-by: Namanl2001 namanlakhwani@gmail.com

changes as per discussion here: #24308 (comment)

Ref: kubernetes/kubernetes#106478

cc: @dims @amwat @SergeyKanzhelev

@Namanl2001
adding extra ref
7b70ebc 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Namanl2001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 18, 2021
@Namanl2001
sig-node-critical
095790e 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
Namanl2001
Namanl2001 commented Nov 18, 2021
View reviewed changes
config/jobs/kubernetes/sig-node/node-kubelet.yaml
@@ -54,7 +59,7 @@ periodics:
annotations:
fork-per-release: "true"
fork-per-release-periodic-interval: 1h 2h 6h 24h
testgrid-dashboards: sig-node-release-blocking
testgrid-dashboards: sig-node-critical
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: #24388 (comment)

endocrimes
endocrimes reviewed Nov 18, 2021
View reviewed changes
config/jobs/kubernetes/sig-node/node-docker.yaml
extra_refs:
- org: kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to why this is needed here but not on the presubmit kubetest2 jobs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presubmits are always associated with the repository they are configured against and it is automatically checked out. Periodic jobs are ideally supposed to be agnostic of any repo, hence any repo needs to be explicitly checked out if required.

amwat
amwat reviewed Nov 18, 2021
View reviewed changes
config/jobs/kubernetes/sig-node/node-docker.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes/sig-node/node-docker.yaml
extra_refs:
- org: kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presubmits are always associated with the repository they are configured against and it is automatically checked out. Periodic jobs are ideally supposed to be agnostic of any repo, hence any repo needs to be explicitly checked out if required.

@Namanl2001
remove branches:
f8191ec 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@amwat
Copy link
Contributor

amwat commented Nov 22, 2021

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2021
endocrimes
endocrimes approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @dims @SergeyKanzhelev

@dims
Copy link
Member

dims commented Nov 23, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, endocrimes, Namanl2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8486ccb into kubernetes:master Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

@Namanl2001: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-docker.yaml using file config/jobs/kubernetes/sig-node/node-docker.yaml
  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

Signed-off-by: Namanl2001 namanlakhwani@gmail.com

changes as per discussion here: #24308 (comment)

Ref: kubernetes/kubernetes#106478

cc: @dims @amwat @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Namanl2001
Copy link
Member Author

Both jobs are green now 💯

https://testgrid.k8s.io/sig-node-docker#docker-node-conformance-kubetest2
https://testgrid.k8s.io/sig-node-critical#node-kubelet-master-kubetest2

@Namanl2001 Namanl2001 mentioned this pull request Nov 23, 2021
Closed
@Namanl2001 Namanl2001 deleted the fix branch November 23, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat amwat left review comments

@endocrimes endocrimes endocrimes approved these changes

@karan karan Awaiting requested review from karan

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dims dims

@endocrimes endocrimes

@SergeyKanzhelev SergeyKanzhelev

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@Namanl2001 @k8s-ci-robot @amwat @dims @endocrimes @SergeyKanzhelev