Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][sig-node] node-kubelet-master-kubetest2, docker-node-conformance-kubetest2 #24409

Merged
merged 3 commits into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion config/jobs/kubernetes/sig-node/node-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ periodics:
- name: ci-docker-node-conformance-kubetest2
interval: 2h
decorate: true
path_alias: k8s.io/kubernetes
extra_refs:
- org: kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to why this is needed here but not on the presubmit kubetest2 jobs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presubmits are always associated with the repository they are configured against and it is automatically checked out. Periodic jobs are ideally supposed to be agnostic of any repo, hence any repo needs to be explicitly checked out if required.

repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
- org: kubernetes
repo: test-infra
base_ref: master
Expand Down
7 changes: 5 additions & 2 deletions config/jobs/kubernetes/sig-node/node-kubelet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ periodics:
cluster: k8s-infra-prow-build
interval: 1h
decorate: true
path_alias: k8s.io/kubernetes
extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
- org: kubernetes
repo: test-infra
base_ref: master
Expand All @@ -54,7 +57,7 @@ periodics:
annotations:
fork-per-release: "true"
fork-per-release-periodic-interval: 1h 2h 6h 24h
testgrid-dashboards: sig-node-release-blocking
testgrid-dashboards: sig-node-critical
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testgrid-tab-name: node-kubelet-master-kubetest2
testgrid-alert-email: kubernetes-sig-node-test-failures@googlegroups.com
description: "Uses kubetest2 to run a subset of node-e2e tests (+NodeConformance, -Flaky|Serial)"
Expand Down