Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove issue comment on pull-kubernetes-node-e2e-containerd #18412

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

hasheddan
Copy link
Contributor

This job was previously disabled in #18356 due to consistent timeout, which has
now been addressed by moving it to a new GCP project in #18409.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

/cc @dims @liggitt

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 21, 2020
@dims
Copy link
Member

dims commented Jul 21, 2020

/approve
/assign @spiffxp @BenTheElder

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@hasheddan
Copy link
Contributor Author

@spiffxp @BenTheElder could one of you give a lgtm if this looks okay?

@BenTheElder
Copy link
Member

cc @liggitt

we've been working to minimize the number of default presubmit jobs (as opposed to postsubmit, periodic) which are especially resource heavy (run on every pushed commit) and increase the odds of a flake blocking merges

@BenTheElder
Copy link
Member

I'm not sure what the cost/benefit is on this job specifically, or if we'd also wind up with yet another one for cri-o.

see also discussion in kubernetes/kubernetes#92937

@liggitt
Copy link
Member

liggitt commented Jul 23, 2020

starting with this in a periodic job with good alerting, and a run_always: false PR job that can be manually triggered when desired would be my recommendation

if we see the periodic job getting broken frequently due to merged changes the other node e2e doesn't catch we can consider ways to prevent that

@hasheddan
Copy link
Contributor Author

@liggitt sounds good, will update

@hasheddan
Copy link
Contributor Author

@dims should this still have name pull-kubernetes-node-e2e-containerd as a periodic job?

@dims
Copy link
Member

dims commented Jul 25, 2020

@hasheddan we have a periodic CI job already if i remember right

@hasheddan
Copy link
Contributor Author

@dims there are a few e2e containerd node tests it looks like. If those are sufficient is any action needed here? I guess we could just drop the comment about re-enabling for now

@dims
Copy link
Member

dims commented Jul 26, 2020

@hasheddan +1

This job was previously disabled in kubernetes#18356 due to consistent timeout,
which has now been addressed by moving it to a new GCP project in kubernetes#18409.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan changed the title Re-enable pull-kubernetes-node-e2e-containerd Remove issue comment on pull-kubernetes-node-e2e-containerd Jul 27, 2020
@hasheddan
Copy link
Contributor Author

@dims okay I think this is ready now :)

@dims
Copy link
Member

dims commented Jul 27, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d86686c into kubernetes:master Jul 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 27, 2020
@k8s-ci-robot
Copy link
Contributor

@hasheddan: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

This job was previously disabled in #18356 due to consistent timeout, which has
now been addressed by moving it to a new GCP project in #18409.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

/cc @dims @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants