-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove issue comment on pull-kubernetes-node-e2e-containerd #18412
Conversation
/approve |
@spiffxp @BenTheElder could one of you give a lgtm if this looks okay? |
cc @liggitt we've been working to minimize the number of default presubmit jobs (as opposed to postsubmit, periodic) which are especially resource heavy (run on every pushed commit) and increase the odds of a flake blocking merges |
I'm not sure what the cost/benefit is on this job specifically, or if we'd also wind up with yet another one for cri-o. see also discussion in kubernetes/kubernetes#92937 |
starting with this in a periodic job with good alerting, and a run_always: false PR job that can be manually triggered when desired would be my recommendation if we see the periodic job getting broken frequently due to merged changes the other node e2e doesn't catch we can consider ways to prevent that |
@liggitt sounds good, will update |
@dims should this still have name |
@hasheddan we have a periodic CI job already if i remember right |
@dims there are a few e2e containerd node tests it looks like. If those are sufficient is any action needed here? I guess we could just drop the comment about re-enabling for now |
@hasheddan +1 |
This job was previously disabled in kubernetes#18356 due to consistent timeout, which has now been addressed by moving it to a new GCP project in kubernetes#18409. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
731f8fd
to
0f473b5
Compare
@dims okay I think this is ready now :) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, hasheddan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hasheddan: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This job was previously disabled in #18356 due to consistent timeout, which has
now been addressed by moving it to a new GCP project in #18409.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
/cc @dims @liggitt