Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch gcp project for pull-kubernetes-node-e2e-containerd #18409

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Switch gcp project for pull-kubernetes-node-e2e-containerd #18409

merged 1 commit into from
Jul 21, 2020

Conversation

dims
Copy link
Member

@dims dims commented Jul 21, 2020 •
edited
Loading

k8s-c8d-pr-node-e2e went stale a while ago, this is one of the last jobs
that still references this gcp project. Switching this over to the pool
meant for the node-e2e jobs

References:

Note that this job was essentially switched off in #18356, will switch it back on in a subsequent PR if this works

Signed-off-by: Davanum Srinivas davanum@gmail.com

@dims
Switch gcp project for pull-kubernetes-node-e2e-containerd
eb81d91 
k8s-c8d-pr-node-e2e went stale a while ago, this is one of the last jobs
that still references this gcp project. Switching this over to the pool
meant for the node-e2e jobs

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2020
@dims
Copy link
Member Author

dims commented Jul 21, 2020

/assign @hasheddan

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs labels Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 21, 2020
hasheddan
hasheddan approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1af01ef into kubernetes:master Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

@dims: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

k8s-c8d-pr-node-e2e went stale a while ago, this is one of the last jobs
that still references this gcp project. Switching this over to the pool
meant for the node-e2e jobs

References:

Note that this job was essentially switched off in #18356, will switch it back on in a subsequent PR if this works

Signed-off-by: Davanum Srinivas davanum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hasheddan added a commit to hasheddan/test-infra that referenced this pull request Jul 21, 2020
@hasheddan
Re-enable pull-kubernetes-node-e2e-containerd
731f8fd 
This job was previously disabled in kubernetes#18356 due to consistent timeout, which has
now been addressed by moving it to a new GCP project in kubernetes#18409.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan mentioned this pull request Jul 21, 2020
Merged
hasheddan added a commit to hasheddan/test-infra that referenced this pull request Jul 27, 2020
@hasheddan
Remove issue comment on pull-kubernetes-node-e2e-containerd
0f473b5 
This job was previously disabled in kubernetes#18356 due to consistent timeout,
which has now been addressed by moving it to a new GCP project in kubernetes#18409.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@spiffxp spiffxp mentioned this pull request Jun 17, 2021
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@vpickard vpickard Awaiting requested review from vpickard

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dims @k8s-ci-robot @hasheddan