Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jobs] use node-e2e-project boskos pool for ci-containerd-node-e2e #17452

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

hasheddan
Copy link
Contributor

Trying same change made in #17349

Ref: kubernetes/kubernetes#89847

Signed-off-by: hasheddan georgedanielmangum@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 30, 2020
@hasheddan
Copy link
Contributor Author

/cc @spiffxp @saschagrunert

@@ -101,7 +101,7 @@ presubmits:
- --scenario=kubernetes_e2e
- --
- --deployment=node
- --gcp-project=k8s-c8d-pr-node-e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have enough capacity in this pool to handle presubmits, can you try with a ci- job that uses this project first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffxp hmm I don't see any other jobs that use this specific project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try this one in cri-containerd-node-e2e https://testgrid.k8s.io/sig-node-containerd#containerd-node-conformance

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan changed the title [jobs] use node-e2e-project boskos pool for pull-kubernetes-node-e2e-containerd presubmit [jobs] use node-e2e-project boskos pool for ci-containerd-node-e2e Apr 30, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0779325 into kubernetes:master Apr 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

@hasheddan: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key containerd.yaml using file config/jobs/kubernetes/sig-node/containerd.yaml

In response to this:

Trying same change made in #17349

Ref: kubernetes/kubernetes#89847

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants