Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canary jobs for ci-kubernetes-build job variants. #19904

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Add canary jobs for ci-kubernetes-build job variants. #19904

merged 1 commit into from
Nov 10, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Nov 10, 2020 •
edited
Loading

Ensure the job variants of ci-kubernetes-build are successful on k8s-infra-prow-build cluster.
Ref : #19483
Part of: #18549

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 10, 2020
@ameukam ameukam changed the title Add canary job for ci-kubernetes-build jobs variants. Add canary jobs for ci-kubernetes-build job variants. Nov 10, 2020
@ameukam
Copy link
Member Author

ameukam commented Nov 10, 2020

/assign @justaugustus @hasheddan @cpanato
FYI @kubernetes/ci-signal

justaugustus
justaugustus suggested changes Nov 10, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam -- Some changes needed.

config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml Show resolved Hide resolved
config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml Show resolved Hide resolved
config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml Show resolved Hide resolved
config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml Outdated Show resolved Hide resolved
@ameukam ameukam force-pushed the GH-19483 branch 2 times, most recently from c13249d to 3d2c36e Compare November 10, 2020 15:45
@ameukam
Add canary job for ci-kubernetes-build jobs variants.
9f0d9c8 
Ref : kubernetes#19483
Part of: kubernetes#18549

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
cpanato
cpanato approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 75af433 into kubernetes:master Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml

In response to this:

Ensure the job variants of ci-kubernetes-build are successful on k8s-infra-prow-build cluster.
Ref : #19483
Part of: #18549

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp mentioned this pull request Nov 20, 2020
Closed
@SataQiu SataQiu mentioned this pull request Jan 25, 2021
Merged
@spiffxp spiffxp mentioned this pull request Jul 29, 2021
Closed
42 tasks
@ameukam ameukam deleted the GH-19483 branch March 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@cpanato cpanato cpanato approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@justaugustus justaugustus

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @k8s-ci-robot @justaugustus @cpanato @hasheddan