-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ci-kubernetes-build-1-20-canary job #20586
add ci-kubernetes-build-1-20-canary job #20586
Conversation
/cc @neolit123 |
We explicitly didn't include the canary job. /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
I am not sure why this wasn't included, all 1.20 release blocking jobs should be pulling artifacts from community-owned infra? At some point we need to decide "canary" is the wrong term here. One set of jobs publishes to "old" bucket, one set publishes to "new" bucket, and we're transitioning everything to use "new" by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
should we unhold?
and thanks @SataQiu !
ping @justaugustus ! |
I've got to circle back with the team; sorry for blocking here. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, SataQiu, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@SataQiu: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
note this didn't fix the missing new artifacts: |
kubernetes/kubeadm#2380 (comment)
@spiffxp @justaugustus do you know why it's failing? |
@kubernetes/release-engineering -- PTAL ^^ |
Fix: kubernetes/kubeadm#2380
Ref: #19483 #19904
We seem to have forgotten to add the canary job for release-1.20 branch ?
Not sure if it will be possible to just discard the old
kubernetes-release-dev
bucket in 1.20.