Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci-kubernetes-build-1-20-canary job #20586

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jan 25, 2021

Fix: kubernetes/kubeadm#2380
Ref: #19483 #19904

We seem to have forgotten to add the canary job for release-1.20 branch ?
Not sure if it will be possible to just discard the old kubernetes-release-dev bucket in 1.20.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 25, 2021
@SataQiu
Copy link
Member Author

SataQiu commented Jan 25, 2021

/cc @neolit123

@justaugustus
Copy link
Member

We explicitly didn't include the canary job.
Will look into this later today.

/hold
/assign
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
I am not sure why this wasn't included, all 1.20 release blocking jobs should be pulling artifacts from community-owned infra? At some point we need to decide "canary" is the wrong term here. One set of jobs publishes to "old" bucket, one set publishes to "new" bucket, and we're transitioning everything to use "new" by default.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2021
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
should we unhold?

and thanks @SataQiu !

@SataQiu
Copy link
Member Author

SataQiu commented Jan 27, 2021

ping @justaugustus !

@justaugustus
Copy link
Member

I am not sure why this wasn't included, all 1.20 release blocking jobs should be pulling artifacts from community-owned infra? At some point we need to decide "canary" is the wrong term here. One set of jobs publishes to "old" bucket, one set publishes to "new" bucket, and we're transitioning everything to use "new" by default.

I've got to circle back with the team; sorry for blocking here.
I was hoping that we would've had the jobs all cut over, which would've made this "canary" one unnecessary.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, SataQiu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 14a5ac1 into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

@SataQiu: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.20.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.20.yaml

In response to this:

Fix: kubernetes/kubeadm#2380
Ref: #19483 #19904

We seem to have forgotten to add the canary job for release-1.20 branch ?
Not sure if it will be possible to just discard the old kubernetes-release-dev bucket in 1.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

note this didn't fix the missing new artifacts:
kubernetes/kubeadm#2380 (comment)

@neolit123
Copy link
Member

kubernetes/kubeadm#2380 (comment)

It seems that the job did not execute successfully.
https://testgrid.k8s.io/sig-release-1.20-blocking#build-1.20

looking at the logs i don't understand why it's failing. i see this:

W0128 15:18:14.861] subprocess.CalledProcessError: Command '('../release/push-build.sh', '--nomock', '--verbose', '--ci', '--bucket=k8s-release-dev', '--docker-registry=gcr.io/k8s-staging-ci-images', '--extra-version-markers=k8s-beta', '--allow-dup')' returned non-zero exit status 1

@spiffxp @justaugustus do you know why it's failing?

@justaugustus
Copy link
Member

@kubernetes/release-engineering -- PTAL ^^

@spiffxp
Copy link
Member

spiffxp commented Jan 28, 2021

#20624 will fix, but it's blocked from merging by #20628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeadm: fix broken e2e tests for 1.21
5 participants