Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs/cluster-api: bump kubekins to v20220428-de61deb68b-1.24 for main periodics #26156

Merged
merged 1 commit into from
Jun 7, 2022
Merged

jobs/cluster-api: bump kubekins to v20220428-de61deb68b-1.24 for main periodics #26156

merged 1 commit into from
Jun 7, 2022

Conversation

palnabarun
Copy link
Member

Signed-off-by: Nabarun Pal pal.nabarun95@gmail.com

/assign @sbueringer

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 30, 2022
@dims
Copy link
Member

dims commented Apr 30, 2022

/approve
/lgtm

/hold for additional reviews if needed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2022
@sbueringer
Copy link
Member

/lgtm

wait until after we verified the presubmits

This was referenced May 10, 2022
Merged
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2022
@dims
Copy link
Member

dims commented Jun 1, 2022

@palnabarun @sbueringer still need this?

@sbueringer
Copy link
Member

@palnabarun @sbueringer still need this?

Yes, has some correlation with a PR in the CAPI repo which I hope we will merge soon

@palnabarun palnabarun force-pushed the cluster-api-main-periodics-bump-kubekins branch from 2a0e67c to f28c2bf Compare June 7, 2022 06:10
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 7, 2022
@palnabarun palnabarun force-pushed the cluster-api-main-periodics-bump-kubekins branch from f28c2bf to 7b493ae Compare June 7, 2022 06:18
@palnabarun
jobs/cluster-api: bump kubekins to v20220523-f2a2939508-1.24 for main…
104dea9 
… periodics

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun palnabarun force-pushed the cluster-api-main-periodics-bump-kubekins branch from 7b493ae to 104dea9 Compare June 7, 2022 06:21
@sbueringer
Copy link
Member

Thx!

/lgtm
(waiting with hold cancel for a verification of the presubmit jobs)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@sbueringer
Copy link
Member

/hold cancel

presubmit tests are green, verified here: kubernetes-sigs/cluster-api#6600

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit a187ad4 into kubernetes:master Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

@palnabarun: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml

In response to this:

Signed-off-by: Nabarun Pal pal.nabarun95@gmail.com

/assign @sbueringer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@davidewatson davidewatson Awaiting requested review from davidewatson

Assignees

@dims dims

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@palnabarun @dims @k8s-ci-robot @sbueringer