Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster API jobs update to Kubernetes 1.24 #26196

Merged
merged 1 commit into from
May 26, 2022
Merged

Cluster API jobs update to Kubernetes 1.24 #26196

merged 1 commit into from
May 26, 2022

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented May 4, 2022 •
edited

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Update the jobs related to Cluster API to test with the latests Kubernetes release.

Part of kubernetes-sigs/cluster-api#5968

@sbueringer @fabriziopandini

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2022
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label May 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from detiber May 4, 2022 18:58
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 4, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2022
@killianmuldoon
Copy link
Contributor Author

/retest

1 similar comment
@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

Let's merge those first:

I think we should not add upgrade jobs to v0.4 and v1.0, but to v1.1 instead. (similar for pre-submits)

@sbueringer
Copy link
Member

@killianmuldoon Just fyi, the test looks strange but there are actual lint errors somewhere in the middle :) (grep for error). Everything else seems to be just noise.

@sbueringer sbueringer mentioned this pull request May 12, 2022
Closed
33 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2022
@killianmuldoon killianmuldoon changed the title [WIP] Cluster API jobs update to Kubernetes 1.24 Cluster API jobs update to Kubernetes 1.24 May 25, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2022
sbueringer
sbueringer reviewed May 25, 2022
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
- name: ETCD_VERSION_UPGRADE_TO
value: "3.5.3-0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep 3.5.3 given that kubeadm didn't bump with v1.24 and we try to align to that usually? (not even on master)

If yes, let's make sure the other updated/added jobs are using 3.5.3 as well.

config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-1-upgrades.yaml Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Update:
Current plan is to merge this PR after: kubernetes-sigs/cluster-api#6513 has been merged.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@killianmuldoon
Cluster API jobs update to Kubernetes 1.24
7702024 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@sbueringer
Copy link
Member

/hold cancel

PR in CAPI merged, let's see what happens (I'll check testgrid tomorrow)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit dfcc609 into kubernetes:master May 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 26, 2022
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-periodics-release-1-1-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-1-upgrades.yaml
  • key cluster-api-periodics-release-1-1.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-1.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Update the jobs related to Cluster API to test with the latests Kubernetes release.

Part of kubernetes-sigs/cluster-api#5968

@sbueringer @fabriziopandini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@detiber detiber Awaiting requested review from detiber

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@killianmuldoon @sbueringer @k8s-ci-robot