Update bazel image to use multirepo-compatible bootstrap args

[ixdy]

Additionally, update test-infra jobs to use new bazelbuild image.

Part of #2704.

I think this might work, but I have no idea how to test it. As such, I'm planning to test only on the test-infra repo to start.

/assign @spxtr

[spxtr]

You can run bootstrap locally. Once you push the new image, you can run it on prow manually. Go to a recent job you want to run on https://prow.k8s.io. Click the ⟳ and download the YAML file at the end of the kubectl create call. Modify it with your change, then kubectl create -f it.

[spxtr]

(This will obviously be made much easier in the future)

[ixdy]

Running locally won't tell me if the PULL_REFS var is being used properly, since I don't know how to construct that.

The prow tip is a good idea.

[ixdy]

I'm sure there is a reason we don't just put coalesce.py into the bazelbuild image, right?

[spxtr]

There is no reason, and it's a pain that your PR will fail tests because it can't find coalesce.py.

[ixdy]

I'm going to undo my rename change, but I'm going to stick coalesce.py in the image, which will hopefully make this rename easier in a future change.

[ixdy]

PTAL.

[spxtr]

LGTM, have you run the test on prow?

[ixdy]

answer: nope, doesn't work: https://prow.k8s.io/log?pod=ci-test-infra-bazel-54459

Cloning into 'test-infra'...
Traceback (most recent call last):
  File "./test-infra/jenkins/bootstrap.py", line 957, in <module>
    bootstrap(ARGS)
  File "./test-infra/jenkins/bootstrap.py", line 834, in bootstrap
    repos = parse_repos(args)
  File "./test-infra/jenkins/bootstrap.py", line 823, in parse_repos
    raise ValueError('branch:commit must also specify PRs to merge', repos)
ValueError: ('branch:commit must also specify PRs to merge', ['k8s.io/test-infra=master:593074a90647419e6a3bab82c27f2b2246e7d21f'])

[spxtr]

Yay, we prevented a minor outage!

[pipejakob]

I suspect that an absolute path reference like this is going to make this job harder to test locally (outside of the image). I don't know if that's a non-goal of this particular job, but in general, I thought we tried to have jobs that we could run using just bootstrap.py or even just directly, if you've set up your environment properly.

How do you feel about stripping the leading slash and just making sure that the script is in $PATH to find it? You'll likely have to add / to the PATH in the Dockerfile, but it seems like that would be more forgiving to local development.

[ixdy]

fair point, though I think

export TEST_TMPDIR="/root/.cache/bazel"

is already going to fail outside of docker.

long-term I think we want to convert this into a scenario, anyway.

[ixdy]

It seems like bootstrap.py allows --repo=foo --branch=$PULL_REFS, but it doesn't allow --repo=foo=$PULL_REFS, which I believe should be equivalent. Is there any reason to explicitly disallow this?

[krzyzacy]

--repo=k8s.io/foo=master:abcd?

[ixdy]

yes, I expect that to work. it doesn't right now.

[ixdy]

I'm pretty sure there's already a code path to handle checking out a particular commit on a branch not in PR-mode, though. There's even a unit test for this functionality.

Sent #2831 to remove the check. It seems like the unit tests still work as expected.

[ixdy]

@k8s-bot test this

[ixdy]

For fun, I also updated bazel and gcloud in the image.

Things seem to work now, except that bazel 0.5.0 apparently doesn't work on the test-infra repo.

[ixdy]

potential fix for bazel 0.5 in pubref/rules_node#21. (We'll need to update our reference, too, of course)

[ixdy]

It all seems to work correctly now. PTAL?

[spxtr]

/lgtm
Assuming you ran the test manually.

[ixdy]

yeah, https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/test-infra/2731/pull-test-infra-bazel/3532/