Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bootstrap.py --repo=$REPO=$BRANCH:$COMMIT #2831

Merged
merged 1 commit into from
May 26, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented May 23, 2017

--repo=$REPO --branch=$BRANCH:$COMMIT was already supported.

See #2731 for discussion.

/assign @fejta @krzyzacy

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2017
@krzyzacy
Copy link
Member

/lgtm

makes sense, not sure why it's originally disabled though @fejta

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2017
@fejta
Copy link
Contributor

fejta commented May 23, 2017

Hmm... Probably because --repo=master:deadbeef --pull=1234 will do weird stuff, aka not actually do what you want.

So maybe ensure this format doesn't use --branch or --pull?

@fejta
Copy link
Contributor

fejta commented May 23, 2017

/lgtm btw

@ixdy ixdy force-pushed the bootstrap-repo-branch-ref branch from c9dbdff to 95a5dba Compare May 26, 2017 21:24
--repo=$REPO --branch=$BRANCH:$COMMIT was already supported.
@ixdy ixdy force-pushed the bootstrap-repo-branch-ref branch from 95a5dba to 3aee839 Compare May 26, 2017 21:24
@ixdy
Copy link
Member Author

ixdy commented May 26, 2017

Updated logic so something like --repo=something=branch:commit --pull=123 is disallowed, since that case doesn't work and isn't worth fixing. (If you want that, just use the new repo syntax.)

@ixdy
Copy link
Member Author

ixdy commented May 26, 2017

unit tests pass, please take one last look?

@krzyzacy
Copy link
Member

lgtm still

@ixdy ixdy merged commit 757dfae into kubernetes:master May 26, 2017
@ixdy ixdy deleted the bootstrap-repo-branch-ref branch May 15, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants