Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate kind to community cluster #30243

Closed
wants to merge 1 commit into from
Closed

migrate kind to community cluster #30243

wants to merge 1 commit into from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jul 31, 2023 •
edited

This PR moves the kind jobs from the GCP cluster to the community owned EKS cluster.

ref: #29722

note: This PR Only update for all of the job in the default cluster: https://prow.k8s.io/?repo=kubernetes-sigs%2Fkind&cluster=default

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2023
@liangyuanpeng liangyuanpeng marked this pull request as draft July 31, 2023 05:22
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @liangyuanpeng!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liangyuanpeng
Once this PR has been reviewed and has the lgtm label, please assign munnerz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng liangyuanpeng changed the title move kind ci migrate kind to community cluster Jul 31, 2023
@liangyuanpeng liangyuanpeng marked this pull request as ready for review July 31, 2023 06:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@jmguzik
Copy link
Contributor

jmguzik commented Jul 31, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2023
aojea
aojea reviewed Jul 31, 2023
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml Outdated
resources:
limits:
cpu: "2"
memory: 4Gi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 9G in the other cluster to avoid flakiness

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

      resources:
        limits:
          cpu: "4"
          memory: 9000Mi
        requests:
          cpu: "4"
          memory: 9000Mi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

BenTheElder
BenTheElder reviewed Jul 31, 2023
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml Outdated
@@ -16,6 +17,13 @@ presubmits:
# we need privileged mode in order to do docker in docker
securityContext:
privileged: true
resources:
limits:
cpu: "2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fairly low for compiling and will just make the job run longer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@liangyuanpeng
migrate kind to community cluster
4637a65 
Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng liangyuanpeng changed the title migrate kind to community cluster migrate kind to community cluster Aug 1, 2023
liangyuanpeng
liangyuanpeng commented Aug 1, 2023
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind.yaml
@@ -27,7 +35,7 @@ periodics:
# conformance test against kubernetes master branch with `kind`
- interval: 1h
name: ci-kubernetes-kind-conformance
cluster: k8s-infra-prow-build
cluster: eks-prow-build-cluster
Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Aug 1, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the cgroup v2 for EKS before change it?
related:

cc @BenTheElder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should migrate it on the next time.

@liangyuanpeng liangyuanpeng mentioned this pull request Oct 19, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjsadow
Copy link
Contributor

rjsadow commented Jan 21, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@rjsadow: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea aojea left review comments

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liangyuanpeng @k8s-ci-robot @jmguzik @rjsadow @BenTheElder @aojea