Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate kind jobs to community cluster #31064

Closed
wants to merge 1 commit into from
Closed

migrate kind jobs to community cluster #31064

wants to merge 1 commit into from

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Oct 18, 2023

This PR moves promo-tools jobs to the community owned cluster.

ref: #30277

/cc @BenTheElder @munnerz @neolit123 @aojea
/cc @ameukam

@rjsadow
migrate kind jobs to community cluster
8b8ccb1 
Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rjsadow
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 18, 2023
@ameukam
Copy link
Member

ameukam commented Oct 18, 2023

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@neolit123
Copy link
Member

neolit123 commented Oct 18, 2023 •
edited
Loading

FWIW, we rolled back the kinder jobs to the google cluster, due to resource problems at the community cluster. @xmudrii @ameukam may have more context.

also we have k/kubeadm pre-pull canaries that run on the community cluster and they are failing with a strange "pod" error -
pull-kubeadm-kinder-upgrade-latest-canary , pull-kubeadm-kinder-verify-canary, so we had to enable the /skip plugin.

BenTheElder
BenTheElder reviewed Oct 18, 2023
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind-postsubmits.yaml
@@ -17,6 +18,13 @@ postsubmits:
# we need privileged mode in order to do docker in docker
securityContext:
privileged: true
resources:
limits:
cpu: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems pretty low for unit testing?
also kind doesn't have the hack to enable GOMAXPROCS autodetection so we need to consider this when moving unit tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to bump it up. Do you have any recommendations?

@liangyuanpeng
Copy link
Contributor

The job of Kind have some problem need to check. Maybe there are not ready to migrate.

#30243 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam
Copy link
Member

ameukam commented Jan 15, 2024

@rjsadow Apologies. I thought those jobs were forgotten. 🤦🏾

@rjsadow
Copy link
Contributor Author

rjsadow commented Jan 15, 2024

Not a problem. Glad they finally got moved!

@rjsadow rjsadow closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@ameukam ameukam Awaiting requested review from ameukam

@aojea aojea Awaiting requested review from aojea

@munnerz munnerz Awaiting requested review from munnerz

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@ameukam ameukam

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rjsadow @k8s-ci-robot @ameukam @neolit123 @liangyuanpeng @BenTheElder