Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a do-not-merge/needs-area label to cluster-api #30314

Merged
merged 1 commit into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions config/prow/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,7 @@ tide:
- kubernetes/sample-cli-plugin
- kubernetes/sample-controller
- kubernetes-sigs/cloud-provider-azure
- kubernetes-sigs/cluster-api
labels:
- lgtm
- approved
Expand Down Expand Up @@ -772,6 +773,23 @@ tide:
- do-not-merge/work-in-progress
- needs-rebase
- needs-kind
- repos:
mjlshen marked this conversation as resolved.
Show resolved Hide resolved
- kubernetes-sigs/cluster-api
labels:
- lgtm
- approved
- "cncf-cla: yes"
missingLabels:
mjlshen marked this conversation as resolved.
Show resolved Hide resolved
mjlshen marked this conversation as resolved.
Show resolved Hide resolved
- do-not-merge
- do-not-merge/blocked-paths
- do-not-merge/contains-merge-commits
- do-not-merge/hold
- do-not-merge/invalid-commit-message
- do-not-merge/invalid-owners-file
- do-not-merge/needs-area
- do-not-merge/release-note-label-needed
- do-not-merge/work-in-progress
- needs-rebase
merge_method:
kubernetes-client/csharp: squash
kubernetes-client/gen: squash
Expand Down
12 changes: 12 additions & 0 deletions config/prow/plugins.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,18 @@ require_matching_label:
issues: true
prs: true
regexp: ^priority/
- missing_label: do-not-merge/needs-area
org: kubernetes-sigs
repo: cluster-api
issues: false
prs: true
regexp: ^area/
missing_comment: |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing `/area ${COMPONENT}` in a comment

Please see the [labels list](https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md#labels-that-apply-to-kubernetes-sigscluster-api-for-both-issues-and-prs) for possible areas.
- missing_label: needs-triage
org: kubernetes-sigs
repo: cluster-api
Expand Down
7 changes: 7 additions & 0 deletions label_sync/labels.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [Labels that apply to all repos, only for issues](#labels-that-apply-to-all-repos-only-for-issues)
- [Labels that apply to all repos, only for PRs](#labels-that-apply-to-all-repos-only-for-prs)
- [Labels that apply to kubernetes-sigs/cluster-api, for both issues and PRs](#labels-that-apply-to-kubernetes-sigscluster-api-for-both-issues-and-prs)
- [Labels that apply to kubernetes-sigs/cluster-api, only for PRs](#labels-that-apply-to-kubernetes-sigscluster-api-only-for-prs)
- [Labels that apply to kubernetes-sigs/cluster-api-operator, for both issues and PRs](#labels-that-apply-to-kubernetes-sigscluster-api-operator-for-both-issues-and-prs)
- [Labels that apply to kubernetes-sigs/cluster-api-provider-aws, for both issues and PRs](#labels-that-apply-to-kubernetes-sigscluster-api-provider-aws-for-both-issues-and-prs)
- [Labels that apply to kubernetes-sigs/cluster-api-provider-aws, only for issues](#labels-that-apply-to-kubernetes-sigscluster-api-provider-aws-only-for-issues)
Expand Down Expand Up @@ -223,6 +224,12 @@ larger set of contributors to apply/remove them.
| <a id="kind/proposal" href="#kind/proposal">`kind/proposal`</a> | Issues or PRs related to proposals.| anyone | [label](https://git.k8s.io/test-infra/prow/plugins/label) |
| <a id="kind/release-blocking" href="#kind/release-blocking">`kind/release-blocking`</a> | Issues or PRs that need to be closed before the next CAPI release| approvers | [label](https://git.k8s.io/test-infra/prow/plugins/label) |

## Labels that apply to kubernetes-sigs/cluster-api, only for PRs

| Name | Description | Added By | Prow Plugin |
| ---- | ----------- | -------- | --- |
| <a id="do-not-merge/needs-area" href="#do-not-merge/needs-area">`do-not-merge/needs-area`</a> | PR is missing an area label| prow | [require-matching-label](https://git.k8s.io/test-infra/prow/plugins/require-matching-label) |
mjlshen marked this conversation as resolved.
Show resolved Hide resolved

## Labels that apply to kubernetes-sigs/cluster-api-operator, for both issues and PRs

| Name | Description | Added By | Prow Plugin |
Expand Down
6 changes: 6 additions & 0 deletions label_sync/labels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1878,6 +1878,12 @@ repos:
target: both
prowPlugin: label
addedBy: anyone
- color: e11d21
description: PR is missing an area label
name: do-not-merge/needs-area
mjlshen marked this conversation as resolved.
Show resolved Hide resolved
target: prs
prowPlugin: require-matching-label
addedBy: prow
kubernetes-sigs/cluster-api-operator:
labels:
- color: c7def8
Expand Down