-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a do-not-merge/needs-area
label to cluster-api
#30314
Add a do-not-merge/needs-area
label to cluster-api
#30314
Conversation
Welcome @mjlshen! |
Hi @mjlshen. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
do-not-merge/needs-area
label to cluster-api
24388a8
to
7b21ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to add something here https://github.com/kubernetes/test-infra/blob/master/config/prow/config.yaml#L621
using missingLabels
to block PRs containing do-not-merge/needs-area
from merging.
or is this done by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, one suggestion below:
/ok-to-test |
7b21ea0
to
77c6550
Compare
77c6550
to
e323e41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain this will work - but I think we should be happy to merge it and see the impact unless we get some clearer guidance.
We should definitely bring this change up on the community meeting to signal to contributors and reviewers that this change is being made.
With this change we should also update Cluster API pull request template and mention there that area label is required now. |
As mentioned on the CAPI PR. I would prefer to keep the template short: kubernetes-sigs/cluster-api#8260 (comment) Please also sync up your efforts. I think you're not aware of each other :) |
I'll bring it up today - thanks for the thorough review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit otherwise lgtm
/lgtm |
This label will be added automatically when a PR is missing an "area/*" label in the cluster-api repo, which will block PRs from being merged until an "area/*" label is added. Signed-off-by: Michael Shen <mishen@umich.edu>
e323e41
to
7c66e20
Compare
Alright. Thx everyone for implementing and reviewing this! /lgtm /hold cancel |
Looks like #30335 will fix the job |
/assign @BenTheElder |
/assign @dims Sorry not entirely sure who to assign for which folder |
Ah didn't notice sig-contributor-experience-technical-leads are now approvers for labels /assign @MadhavJivrajani |
/test pull-test-infra-unit-test-race-detector-nonblocking |
/lgtm |
Will take a look today 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment otherwise LGTM!
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, mjlshen, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mjlshen: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This label will be added automatically when a PR is missing an "area/*" label in the cluster-api repo, which will block PRs from being merged until an "area/*" label is added.
kubernetes-sigs/cluster-api#8967