Add a do-not-merge/needs-area label to cluster-api

[mjlshen]

This label will be added automatically when a PR is missing an "area/*" label in the cluster-api repo, which will block PRs from being merged until an "area/*" label is added.

kubernetes-sigs/cluster-api#8967

[k8s-ci-robot]

Welcome @mjlshen!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mjlshen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[g-gaston]

We might need to add something here https://github.com/kubernetes/test-infra/blob/master/config/prow/config.yaml#L621 using missingLabels to block PRs containing do-not-merge/needs-area from merging.
or is this done by default?

[g-gaston]

@nprokopic
@nawazkh
@furkatgofurov7
@willie-yao
@killianmuldoon
@sbueringer

[furkatgofurov7]

Thanks for the PR, one suggestion below:

[furkatgofurov7]

/ok-to-test

[killianmuldoon]

I'm not certain this will work - but I think we should be happy to merge it and see the impact unless we get some clearer guidance.

We should definitely bring this change up on the community meeting to signal to contributors and reviewers that this change is being made.

[nprokopic]

With this change we should also update Cluster API pull request template and mention there that area label is required now.

[sbueringer]

With this change we should also update Cluster API pull request template and mention there that area label is required now.

As mentioned on the CAPI PR. I would prefer to keep the template short: kubernetes-sigs/cluster-api#8260 (comment)

Please also sync up your efforts. I think you're not aware of each other :)

[mjlshen]

I'll bring it up today - thanks for the thorough review!

[sbueringer]

Just one nit otherwise lgtm

[g-gaston]

/lgtm

[sbueringer]

Alright. Thx everyone for implementing and reviewing this!

/lgtm
/approve

/hold cancel

[sbueringer]

Looks like #30335 will fix the job

[sbueringer]

/assign @BenTheElder

[sbueringer]

/assign @dims

Sorry not entirely sure who to assign for which folder

[sbueringer]

Ah didn't notice sig-contributor-experience-technical-leads are now approvers for labels

/assign @MadhavJivrajani

[nawazkh]

/test pull-test-infra-unit-test-race-detector-nonblocking

[nawazkh]

/lgtm

[MadhavJivrajani]

Will take a look today 👍

[MadhavJivrajani]

One comment otherwise LGTM!

[MadhavJivrajani]

/lgtm
/assign @dims
for approval

[dims]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mjlshen, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/OWNERS [dims]
• label_sync/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@mjlshen: Updated the following 3 configmaps:

• config configmap in namespace default at cluster test-infra-trusted using the following files:
  • key config.yaml using file config/prow/config.yaml
• plugins configmap in namespace default at cluster test-infra-trusted using the following files:
  • key plugins.yaml using file config/prow/plugins.yaml
• label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:
  • key labels.yaml using file label_sync/labels.yaml

In response to this:

This label will be added automatically when a PR is missing an "area/*" label in the cluster-api repo, which will block PRs from being merged until an "area/*" label is added.

kubernetes-sigs/cluster-api#8967

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.