fix: lru race condition #30335
Merged
fix: lru race condition #30335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
requested review from
cblecker,
cjwagner,
droslean,
petr-muller and
stevekuznetsov
|
Ah, good catch. Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx, rjsadow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are ongoing failures in the pull-test-infra-unit-test-race-detector-nonblocking jobs. The failures are related to concurrent access to the underlying LRU cache within the
NewInRepoConfigCachefunction, specifically between thelruCache.Keys()andlruCache.GetOrAdd()calls. These conflicting accesses are causing a data race, as the underlying LRU cache implementation (github.com/hashicorp/golang-lru) does not handle concurrent reads and writes safely. The proposed fix involves adding synchronization around LRU cache Keys operation to ensure that only one goroutine can access the cache at a time, thereby preventing the race condition. Locks are already in place for the GetOrAdd operation.ref: https://kubernetes.slack.com/archives/C09QZ4DQB/p1691588437957859
/cc @listx