Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate sig-network jobs to community cluster #30761

Merged
merged 1 commit into from
Sep 19, 2023
Merged

migrate sig-network jobs to community cluster #30761

merged 1 commit into from
Sep 19, 2023

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Sep 19, 2023

This PR moves the sig-network jobs to the community owned cluster.

ref: #30277

/cc @aojea @bowei @cadmuxe @MrHohn @rramkumar1
/cc @ameukam @dims

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 19, 2023
bowei
bowei reviewed Sep 19, 2023
View reviewed changes
config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml
@@ -185,6 +186,13 @@ periodics:
- --provider=gce
- --test_args=--ginkgo.focus=\[Feature:Ingress\]|\[Feature:NEG\]
- --timeout=320m
resources:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put some discussion of why these resources need to be added and where they are coming from in the commit message?

e.g. so git blame can be used to figure out why these exist and how they were obtained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@rjsadow
migrate sig-network jobs to community cluster
ec30645 
This change moves several sig-network jobs from the Google owned GKE
cluster to the community owned GKE cluster. All jobs running in
community owned clusters must set resource quotas so that the
autoscalers work correctly. These resources were chosen as a best guess
based on related jobs in sig-networking and guidance from
https://github.com/kubernetes/test-infra/blob/master/docs/eks-jobs-migration.md.

Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
@rjsadow
Copy link
Contributor Author

rjsadow commented Sep 19, 2023

/retest

@aojea
Copy link
Member

aojea commented Sep 19, 2023

/lgtm
/approve

moving the ci jobs only

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1304547 into kubernetes:master Sep 19, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rjsadow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

This PR moves the sig-network jobs to the community owned cluster.

ref: #30277

/cc @aojea @bowei @cadmuxe @MrHohn @rramkumar1
/cc @ameukam @dims

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam mentioned this pull request Sep 29, 2023
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@ameukam ameukam Awaiting requested review from ameukam

@aojea aojea Awaiting requested review from aojea

@cadmuxe cadmuxe Awaiting requested review from cadmuxe

@dims dims Awaiting requested review from dims

@MrHohn MrHohn Awaiting requested review from MrHohn

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rjsadow @aojea @k8s-ci-robot @bowei