Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch master branch bazel to kubekins and enable cache for unit tests #7004

Merged

Conversation

BenTheElder
Copy link
Member

xref #6808

Not enabling for build just yet as I want to tweak the cache a little, but unit testing caches extremely well and takes much longer so let's get this enabled and slash test times!

/area jobs
/area bazel

@k8s-ci-robot k8s-ci-robot added area/jobs area/bazel cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2018
@BenTheElder
Copy link
Member Author

/assign @krzyzacy @ixdy

@@ -3068,6 +3070,7 @@ presubmits:
cluster: security
context: pull-security-kubernetes-bazel-test
labels:
preset-bazel-scratch-dir: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are some of these true and some of these "true"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the security repo is auto generated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of our hand written stuff is overly quoted, the security repo has fully auto generated config so it gets whatever quoting is left after being shoved through go's yaml and a python lib.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Feb 26, 2018
@ixdy
Copy link
Member

ixdy commented Feb 26, 2018

/lgtm

this is probably fine

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f00460 into kubernetes:master Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the config configmap

In response to this:

xref #6808

Not enabling for build just yet as I want to tweak the cache a little, but unit testing caches extremely well and takes much longer so let's get this enabled and slash test times!

/area jobs
/area bazel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the code-freeze-code-schmeeze branch February 26, 2018 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants