-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch master branch bazel to kubekins and enable cache for unit tests #7004
switch master branch bazel to kubekins and enable cache for unit tests #7004
Conversation
@@ -3068,6 +3070,7 @@ presubmits: | |||
cluster: security | |||
context: pull-security-kubernetes-bazel-test | |||
labels: | |||
preset-bazel-scratch-dir: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are some of these true
and some of these "true"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the security repo is auto generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of our hand written stuff is overly quoted, the security repo has fully auto generated config so it gets whatever quoting is left after being shoved through go's yaml and a python lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/shrug
/lgtm this is probably fine |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@BenTheElder: Updated the config configmap In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xref #6808
Not enabling for build just yet as I want to tweak the cache a little, but unit testing caches extremely well and takes much longer so let's get this enabled and slash test times!
/area jobs
/area bazel